From: Michael Ellerman <mpe@kernel.org>
To: Austin Kim <austindh.kim@gmail.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: signal: refactor debug logging to use macros
Date: Tue, 31 Mar 2026 14:36:33 +1100 [thread overview]
Message-ID: <248cd5c4-e1ac-4d08-a88a-efb472f94752@kernel.org> (raw)
In-Reply-To: <acn9Yha4JufGcQah@adminpc-PowerEdge-R7525>
On 30/3/2026 15:34, Austin Kim wrote:
> From: Austin Kim <austin.kim@lge.com>
>
> Replace manual #if DEBUG_SIG blocks with a unified DEBUGP macro.
> This will improve code readability.
>
> Signed-off-by: Austin Kim <austin.kim@lge.com>
> ---
> arch/riscv/kernel/compat_signal.c | 10 ++++++----
> arch/riscv/kernel/signal.c | 10 ++++++----
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/arch/riscv/kernel/compat_signal.c b/arch/riscv/kernel/compat_signal.c
> index 6ec4e3425..c82235be7 100644
> --- a/arch/riscv/kernel/compat_signal.c
> +++ b/arch/riscv/kernel/compat_signal.c
> @@ -12,7 +12,11 @@
> #include <asm/ucontext.h>
> #include <asm/vdso.h>
>
> -#define COMPAT_DEBUG_SIG 0
> +#ifdef DEBUG_SIG
> +# define DEBUGP(fmt, args...) pr_info("%s: " fmt, __func__, ##args)
> +#else
> +# define DEBUGP(fmt, args...)
> +#endif
>
> struct compat_sigcontext {
> struct compat_user_regs_struct sc_regs;
> @@ -233,11 +237,9 @@ int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
> regs->a1 = (unsigned long)(&frame->info); /* a1: siginfo pointer */
> regs->a2 = (unsigned long)(&frame->uc); /* a2: ucontext pointer */
>
> -#if COMPAT_DEBUG_SIG
> - pr_info("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n",
> + DEBUGP("SIG deliver (%s:%d): sig=%d pc=%p ra=%p sp=%p\n",
> current->comm, task_pid_nr(current), ksig->sig,
> (void *)regs->epc, (void *)regs->ra, frame);
> -#endif
>
> return 0;
> }
Is there any reason not to use pr_devel()?
Or pr_debug() if enabling it at runtime is desirable (with
CONFIG_DYNAMIC_DEBUG=y).
cheers
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-31 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 4:34 [PATCH] riscv: signal: refactor debug logging to use macros Austin Kim
2026-03-31 3:36 ` Michael Ellerman [this message]
2026-03-31 6:51 ` Austin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248cd5c4-e1ac-4d08-a88a-efb472f94752@kernel.org \
--to=mpe@kernel.org \
--cc=alex@ghiti.fr \
--cc=austindh.kim@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox