Re: [PATCH 1/2] kbuild: Abort make on install failures

Russell King (Oracle)
2024-02-10T10:30:25Z

On Sat, Feb 10, 2024 at 03:46:00PM +0800, Zhang Bingwu wrote:
> From: Zhang Bingwu <xtexchooser@duck.com>
>
> Setting '-e' flag tells shells to exit with error exit code immediately
> after any of commands fails, and causes make(1) to regard recipes as
> failed.
>
> Before this, make will still continue to succeed even after the
> installation failed, for example, for insufficient permission or
> directory does not exist.
>
> Signed-off-by: Zhang Bingwu <xtexchooser@duck.com>
> ---
> arch/arm/boot/install.sh | 2 ++
> arch/arm64/boot/install.sh | 2 ++
> arch/m68k/install.sh | 2 ++
> arch/nios2/boot/install.sh | 2 ++
> arch/parisc/install.sh | 2 ++
> arch/riscv/boot/install.sh | 2 ++
> arch/s390/boot/install.sh | 2 ++
> arch/sparc/boot/install.sh | 2 ++
> arch/x86/boot/install.sh | 2 ++
> 9 files changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/install.sh b/arch/arm/boot/install.sh
> index 9ec11fac7d8d..34e2c6e31fd1 100755
> --- a/arch/arm/boot/install.sh
> +++ b/arch/arm/boot/install.sh
> @@ -17,6 +17,8 @@
> # $3 - kernel map file
> # $4 - default install path (blank if root directory)
>
> +set -e
> +

What about #!/bin/sh -e on the first line, which is the more normal way
to do this for an entire script?

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!