From: Xingyu Wu <xingyu.wu@starfivetech.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
Samin Guo <samin.guo@starfivetech.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] drivers: watchdog: Add StarFive Watchdog driver
Date: Fri, 17 Feb 2023 15:29:00 +0800 [thread overview]
Message-ID: <267ab62d-d680-d505-4183-ccb8c654419e@starfivetech.com> (raw)
In-Reply-To: <c0b03600-13a9-b9e7-e4f3-701fd5b55c86@starfivetech.com>
On 2023/2/17 10:30, Xingyu Wu wrote:
> On 2023/2/16 22:57, Guenter Roeck wrote:
>> On 2/15/23 23:11, Xingyu Wu wrote:
>>> On 2023/2/2 6:46, Guenter Roeck wrote:
>>>> On Mon, Dec 19, 2022 at 05:42:32PM +0800, Xingyu Wu wrote:
>>>>> Add watchdog driver for the StarFive JH7110 SoC.
>>>>>
>>>>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>>>>> +
>>>>> [...]
>>>>> +
>>>>> +static const struct watchdog_info starfive_wdt_ident = {
>>>>> + .options = OPTIONS,
>>>>> + .firmware_version = 0,
>>>>
>>>> It is not necessary to initilize a static variable with 0.
>>>>
>>>>> + .identity = "StarFive Watchdog",
>>>>> +};
>>>
>>> Hi Guenter,
>>>
>>> It would be a compilation error if drop the '0'. I found that other files
>>
>> No.
>>
>>> initialize this static variable as well.
>>>
>>
>> Ah, the old "others do it, so do I" argument.
>> Sorry, that is not a valid argument.
>>
>
> Can I assign ‘firmware_version’ to a macro definition in the probe?
>
Or drop the 'firmware_version' ?
Best regards,
Xingyu Wu
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-02-17 7:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 9:42 [PATCH v2 0/3] Add watchdog driver for StarFive JH7110 RISC-V SoC Xingyu Wu
2022-12-19 9:42 ` [PATCH v2 1/3] dt-bindings: watchdog: Add watchdog for StarFive JH7110 Xingyu Wu
2022-12-19 10:44 ` Krzysztof Kozlowski
2022-12-19 9:42 ` [PATCH v2 2/3] drivers: watchdog: Add StarFive Watchdog driver Xingyu Wu
2023-01-17 6:35 ` Xingyu Wu
2023-02-01 22:46 ` Guenter Roeck
2023-02-10 7:01 ` Xingyu Wu
2023-02-10 15:28 ` Guenter Roeck
2023-02-13 13:29 ` Xingyu Wu
2023-02-13 15:26 ` Guenter Roeck
2023-02-16 7:11 ` Xingyu Wu
2023-02-16 14:57 ` Guenter Roeck
2023-02-17 2:30 ` Xingyu Wu
2023-02-17 7:29 ` Xingyu Wu [this message]
2022-12-19 9:42 ` [PATCH v2 3/3] riscv: dts: starfive: jh7110: Add watchdog node Xingyu Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=267ab62d-d680-d505-4183-ccb8c654419e@starfivetech.com \
--to=xingyu.wu@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox