From: Krzysztof Kozlowski <krzk@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Conor Dooley <conor@kernel.org>
Cc: Thomas Bonnefille <thomas.bonnefille@bootlin.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Inochi Amaoto <inochiama@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: iio: adc: sophgo,cv18xx-saradc.yaml: Add Sophgo SARADC binding documentation
Date: Mon, 8 Jul 2024 09:33:04 +0200 [thread overview]
Message-ID: <304b7bb1-d315-4147-820b-1ec0aa63e759@kernel.org> (raw)
In-Reply-To: <20240708083011.058d0c57@xps-13>
On 08/07/2024 08:30, Miquel Raynal wrote:
> Hi Conor,
>
>>>>> +properties:
>>>>> + compatible:
>>>>> + oneOf:
>>>>> + - items:
>>>>> + - enum:
>>>>> + - sophgo,cv1800b-saradc
>>>>> + - const: sophgo,cv18xx-saradc
>>>>
>>>> I don't think the fallback here makes sense. If there's other devices
>>>> with a compatible programming model added later, we can fall back to the
>>>> cv1800b.
>
> I'm sorry but isn't this slightly disagreeing with the "writing
> bindings" doc pointed in v1? It says,
>
> * DO use fallback compatibles when devices are the same as or a subset
> of prior implementations.
>
> I believe we fall in the "devices are the same" category, so I would
> have myself wrote a similar binding here with a compatible matching
> them all, plus a hardware-implementation-specific compatible as well;
> just in case.
Fallback from one model to another. There is no "another" model here,
but wildcard. There is no such device as cv18xx, right?
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-07-08 7:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 13:42 [PATCH v2 0/3] Add SARADC support on Sophgo SoC Thomas Bonnefille
2024-07-05 13:42 ` [PATCH v2 1/3] dt-bindings: iio: adc: sophgo,cv18xx-saradc.yaml: Add Sophgo SARADC binding documentation Thomas Bonnefille
2024-07-05 15:01 ` Conor Dooley
2024-07-05 15:24 ` Thomas Bonnefille
2024-07-06 12:42 ` Conor Dooley
2024-07-08 6:30 ` Miquel Raynal
2024-07-08 7:33 ` Krzysztof Kozlowski [this message]
2024-07-08 12:23 ` Miquel Raynal
2024-07-08 15:57 ` Jonathan Cameron
2024-07-09 7:27 ` Miquel Raynal
2024-07-08 15:10 ` Thomas Bonnefille
2024-07-05 13:42 ` [PATCH v2 2/3] iio: adc: sophgo-saradc: Add driver for Sophgo SARADC Thomas Bonnefille
2024-07-06 5:16 ` kernel test robot
2024-07-06 10:58 ` Jonathan Cameron
2024-07-06 11:10 ` Jonathan Cameron
2024-07-05 13:42 ` [PATCH v2 3/3] riscv: dts: sophgo: Add SARADC configuration Thomas Bonnefille
2024-07-09 2:10 ` [PATCH v2 0/3] Add SARADC support on Sophgo SoC Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304b7bb1-d315-4147-820b-1ec0aa63e759@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@outlook.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=thomas.bonnefille@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox