From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 139A1C4332F for ; Wed, 13 Dec 2023 09:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eMXaUQ9KdQyyJE9ITwfxRmwZMcESBr2Xh5iqlUEdOWU=; b=qOmXFIUmK1Ny52 LQbgRBJv04M/pTy18pVXIWXQXYRN5k5LxqLb8wFZFuIq4G3tcy7CPGEiU9CaaamZ5l7nfubBUOc/4 Ahsqu7Q9I8BA4YV1SnYUvbRZOCyBgXTG+BlxHKl/1FGjEmnvnF4PSWRWaEbBbasXXGHpF6rbX9AEC RWigj6XTTcIB3ngbzBhzd4QCSBZsVXPO9RVnqVqeoakNJ75jhWNu9yweVZ9EK/ktQGmGJdmGU5Q2H 9K3zfAkn3zezyJli+DNEU2AWj7Wup1OhknINPGPp8ii3lrisCLan7ChvePQF+b3Hn7hXiC1yRcOLL c7B7SzfeOviR5jpqVaBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDLAD-00E6Me-1O; Wed, 13 Dec 2023 09:04:21 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDLA9-00E6KP-1w for linux-riscv@lists.infradead.org; Wed, 13 Dec 2023 09:04:19 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 1C90224E2A6; Wed, 13 Dec 2023 17:03:31 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 13 Dec 2023 17:03:30 +0800 Received: from [192.168.120.47] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 13 Dec 2023 17:03:28 +0800 Message-ID: <30eed909-a0c9-409e-a78e-5961c43a9114@starfivetech.com> Date: Wed, 13 Dec 2023 17:03:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/4] pwm: opencores: Add PWM driver support To: Philipp Zabel , , , , CC: Emil Renner Berthing , Rob Herring , Thierry Reding , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Hal Feng , Paul Walmsley , "Palmer Dabbelt" , Albert Ou References: <20231208094209.1910934-1-william.qiu@starfivetech.com> <20231208094209.1910934-3-william.qiu@starfivetech.com> <92ac0bc4c43fa70ff4bcba44ba4382c0c8ebfb75.camel@pengutronix.de> Content-Language: en-US From: William Qiu In-Reply-To: <92ac0bc4c43fa70ff4bcba44ba4382c0c8ebfb75.camel@pengutronix.de> X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_010417_928288_C35D9FFF X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2023/12/8 19:47, Philipp Zabel wrote: > Hi William, > > On Fr, 2023-12-08 at 17:42 +0800, William Qiu wrote: >> Add driver for OpenCores PWM Controller. And add compatibility code >> which based on StarFive SoC. >> >> Co-developed-by: Hal Feng >> Signed-off-by: Hal Feng >> Signed-off-by: William Qiu >> --- > [...] >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig >> index 4b956d661755..d87e1bb350ba 100644 >> --- a/drivers/pwm/Kconfig >> +++ b/drivers/pwm/Kconfig >> @@ -444,6 +444,18 @@ config PWM_NTXEC >> controller found in certain e-book readers designed by the original >> design manufacturer Netronix. >> >> +config PWM_OCORES >> + tristate "OpenCores PWM support" >> + depends on HAS_IOMEM && OF >> + depends on COMMON_CLK && RESET_CONTROLLER > > There is no need for reset consumers to depend on RESET_CONTROLLER. > Will drop > [...] >> diff --git a/drivers/pwm/pwm-ocores.c b/drivers/pwm/pwm-ocores.c >> new file mode 100644 >> index 000000000000..996ca3805901 >> --- /dev/null >> +++ b/drivers/pwm/pwm-ocores.c >> @@ -0,0 +1,229 @@ > [...] >> +static int ocores_pwm_probe(struct platform_device *pdev) >> +{ > [...] >> + ddata->rst = devm_reset_control_get_optional_exclusive(dev, NULL); > > Missing error handling. > Will add. >> + reset_control_deassert(ddata->rst); > > Missing error handling. > Will add. > Thank you for spending time on this patch series. Best Regards, William > regards > Philipp _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv