From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Dmitry Antipov" <dmantipov@yandex.ru>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Charlie Jenkins" <thecharlesjenkins@gmail.com>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
linux-riscv@lists.infradead.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH v4 3/3] riscv: fix building compressed EFI image
Date: Wed, 15 Apr 2026 11:56:59 +0200 [thread overview]
Message-ID: <33c3e393-eacc-4ac2-97e4-5ce45c1b6604@app.fastmail.com> (raw)
In-Reply-To: <ad9f9543RuV17RnH@ashevche-desk.local>
On Wed, 15 Apr 2026, at 11:52, Andy Shevchenko wrote:
> On Tue, Apr 14, 2026 at 01:26:08PM +0300, Dmitry Antipov wrote:
>> When building vmlinuz.efi with CONFIG_EFI_ZBOOT enabled,
>> '__lshrdi3()' is also needed to fix yet another link error:
>>
>> riscv32-linux-gnu-ld: drivers/firmware/efi/libstub/lib-cmdline.stub.o: in function `__efistub_.L49':
>> __efistub_cmdline.c:(.init.text+0x202): undefined reference to `__efistub___lshrdi3'
>>
>> And since riscv64 can have CONFIG_EFI_ZBOOT but doesn't need these
>> library routines, introduce CONFIG_EFI_ZBOOT_USE_LIBGCC to manage
>> linking of lib-ashldi3.o and lib-lshrdi3.o on riscv32 only.
>
> Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> I think you need a tag from Ard on this.
>
I don't think we need a new Kconfig symbol for this.
Better do something like
zboot-riscv-obj-$(CONFIG_32BIT) += lib-ashldi3.o lib-lshrdi3.o
zboot-obj-$(CONFIG_RISCV) += lib-clz_ctz.o $(zboot-riscv-obj-y)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2026-04-15 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 10:26 [PATCH v4 0/3] riscv32 library enhancements and build fixes Dmitry Antipov
2026-04-14 10:26 ` [PATCH v4 1/3] riscv: add platform-specific double word shifts for riscv32 Dmitry Antipov
2026-04-14 10:26 ` [PATCH v4 2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3() Dmitry Antipov
2026-04-14 10:26 ` [PATCH v4 3/3] riscv: fix building compressed EFI image Dmitry Antipov
2026-04-15 9:52 ` Andy Shevchenko
2026-04-15 9:56 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c3e393-eacc-4ac2-97e4-5ce45c1b6604@app.fastmail.com \
--to=ardb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=dmantipov@yandex.ru \
--cc=linux-efi@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=thecharlesjenkins@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox