Re: [PATCH] RISC-V: Fix do_notify_resume / do_work_pending prototype

["Heiko Stübner" <heiko@sntech.de>]

Am Mittwoch, 18. Januar 2023, 16:40:52 CET schrieb Conor Dooley:
> On Wed, Jan 18, 2023 at 03:22:52PM +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@vrull.eu>
> > 
> > Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to
> > userspace slow-path") renamed the do_notify_resume function to
> > do_work_pending but did not change the prototype in signal.h
> > Do that now, as the original function does not exist anymore.
> > 
> > Fixes: b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path")
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu>
> > ---
> >  arch/riscv/include/asm/signal.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
> > index 532c29ef0376..956ae0a01bad 100644
> > --- a/arch/riscv/include/asm/signal.h
> > +++ b/arch/riscv/include/asm/signal.h
> > @@ -7,6 +7,6 @@
> >  #include <uapi/asm/ptrace.h>
> >  
> >  asmlinkage __visible
> > -void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags);
> > +void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
> 
> Is that an auto-builder blind spot as it gets jumped to from asm?

Yeah, the prototype is seemingly more for show in that case, as I guess
from asm we only look for the symbol itself but nothing will check the
syntax of the parameters.


@Palmer: any thoughts?


Thanks
Heiko



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv