Re: [PATCH v2 5/6] RISC-V: Do no continue isa string parsing without correct XLEN

Geert Uytterhoeven
2022-02-11T12:52:51Z

Hi Andreas,

On Thu, Feb 10, 2022 at 11:00 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Feb 10 2022, Atish Patra wrote:
> > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
> > index 469b9739faf7..cca579bae8a0 100644
> > --- a/arch/riscv/kernel/cpufeature.c
> > +++ b/arch/riscv/kernel/cpufeature.c
> > @@ -84,6 +84,7 @@ void __init riscv_fill_hwcap(void)
> > for_each_of_cpu_node(node) {
> > unsigned long this_hwcap = 0;
> > uint64_t this_isa = 0;
> > + char *temp;
> >
> > if (riscv_of_processor_hartid(node) < 0)
> > continue;
> > @@ -93,6 +94,7 @@ void __init riscv_fill_hwcap(void)
> > continue;
> > }
> >
> > + temp = (char *)isa;
>
> There should be no need for this cast.

Indeed, but only if "temp" is changed to "const char *".

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds