From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D15DAC00140 for ; Wed, 24 Aug 2022 17:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WPOl9F+5hQpNW4yZeKeSRjVuiYsjc54j2H6fp05f85g=; b=VnZfxMQI7kjQW2 jKwPKs58s2DuoIJUe5Z/3968DuA2EcnS9umcHiokx2YK2tt7gHsT24jT04CbicjK2CYiGLHbpJxP3 h6r/58gw1DQjoF6YV4IplOK/Bj5KGMw3NFzGBE6WPB4M+8N1hQIYZ6ZHtHUjr8AS3t7fxTpPZQOiv ad+8t2vpHp3FJtMan/UUl0nrGChPDoX8dARALyRao/0AKJyJRw87+8sl6FdPKN/Zv+XiNelNG1RMe cOdUQB3uE93WxrmPhxc2/cObC0G9QC0zXJGSXK4t7H9JK62mI4BI8hDiyiBIE9BW35oBBsfklR6gQ rQryhakb2zmmLaMGadtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQuQX-00EvM5-RR; Wed, 24 Aug 2022 17:44:29 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQuQV-00EvKU-Iy for linux-riscv@lists.infradead.org; Wed, 24 Aug 2022 17:44:28 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oQuQN-0004jX-Da; Wed, 24 Aug 2022 19:44:19 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Palmer Dabbelt , Paul Walmsley , Albert Ou , linux-riscv@lists.infradead.org Cc: Daniel Lezcano , Anup Patel , Conor Dooley , Guo Ren , Sagar Kadam , Jessica Clarke , Andrew Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, qemu-riscv@nongnu.org, Rob Herring , Conor Dooley Subject: Re: [PATCH v4 2/4] dt-bindings: interrupt-controller: sifive,plic: add legacy riscv compatible Date: Wed, 24 Aug 2022 19:44:18 +0200 Message-ID: <3948407.AJdgDx1Vlc@diego> In-Reply-To: <20220823183319.3314940-3-mail@conchuod.ie> References: <20220823183319.3314940-1-mail@conchuod.ie> <20220823183319.3314940-3-mail@conchuod.ie> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220824_104427_659935_14C13ED7 X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Am Dienstag, 23. August 2022, 20:33:18 CEST schrieb Conor Dooley: > From: Conor Dooley > > While "real" hardware might not use the compatible string "riscv,plic0" > it is present in the driver & QEMU uses it for automatically generated > virt machine dtbs. To avoid dt-validate problems with QEMU produced > dtbs, such as the following, add it to the binding. > > riscv-virt.dtb: plic@c000000: compatible: 'oneOf' conditional failed, one must be fixed: > 'sifive,plic-1.0.0' is not one of ['sifive,fu540-c000-plic', 'starfive,jh7100-plic', 'canaan,k210-plic'] > 'sifive,plic-1.0.0' is not one of ['allwinner,sun20i-d1-plic'] > 'sifive,plic-1.0.0' was expected > 'thead,c900-plic' was expected > riscv-virt.dtb: plic@c000000: '#address-cells' is a required property > > Reported-by: Rob Herring > Link: https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-robh@kernel.org/ > Reviewed-by: Rob Herring > Signed-off-by: Conor Dooley > --- > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 92e0f8c3eff2..99e01f4d0a69 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -66,6 +66,11 @@ properties: > - enum: > - allwinner,sun20i-d1-plic > - const: thead,c900-plic > + - items: > + - const: sifive,plic-1.0.0 > + - const: riscv,plic0 > + deprecated: true hmm, when setting this to deprecated, does this mean qemu was changed to not use that compatible anymore? I.e. reading deprecated I'd assume that this is kept around for old qemu builds? Heiko > + description: For the QEMU virt machine only > > reg: > maxItems: 1 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv