From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFFEBC77B73 for ; Tue, 6 Jun 2023 03:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DJOdyJcJ1NpPOQes7AXVRSHxbBeQtp0Cj/VopUyDSzI=; b=TZ0D8DAv1FzBY0 XSUk4AILzA99tqLzF0EtJ7ZunMOEKGl/d7q+AIkr8TsLuKtnpyvvzXRgpAhrHMTO3rQO3KdRNnv/5 dPmGo8RLC2yHCG/UIyY6vpegbR5Mr6JO78mge/3YJ5wg9RX5ySe68A3BEKhVy/ijSbjea7SEiXPSu QWDQNj/Ipjl0RlweaxEfLSdsdWrijSBO96HDNep4AaNUbbZzKqw6dXfDIJnNBjZ4CbicFFfEL69SL yY/sPEZGU9oq5mcdw2Ig8zkox0jT1e7HtCBqAY4p3IDZiz7hWH2YjZr3Jv96Ym4Gj7gF2sQ+gD6Q1 2kwKPMihS+oseEgHasPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6NT1-00Hac9-22; Tue, 06 Jun 2023 03:34:43 +0000 Received: from fd01.gateway.ufhost.com ([61.152.239.71]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6NSz-00HaZV-1I for linux-riscv@lists.infradead.org; Tue, 06 Jun 2023 03:34:42 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 665C68155; Tue, 6 Jun 2023 11:34:16 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 6 Jun 2023 11:34:16 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 6 Jun 2023 11:34:15 +0800 Message-ID: <39ff6f3f-4713-3864-4325-3dbde811a220@starfivetech.com> Date: Tue, 6 Jun 2023 11:34:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 1/3] dt-bindings: qspi: cdns,qspi-nor: Add clocks for StarFive JH7110 SoC Content-Language: en-US To: Conor Dooley CC: , , , , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Emil Renner Berthing" , Ziv Xu References: <20230602084925.215411-1-william.qiu@starfivetech.com> <20230602084925.215411-2-william.qiu@starfivetech.com> <20230602-impurity-broker-28cc27869b64@spud> From: William Qiu In-Reply-To: <20230602-impurity-broker-28cc27869b64@spud> X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_203441_598856_090AE7F0 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2023/6/3 2:02, Conor Dooley wrote: > On Fri, Jun 02, 2023 at 04:49:23PM +0800, William Qiu wrote: >> The QSPI controller needs three clock items to work properly on StarFive >> JH7110 SoC, so there is need to change the maxItems's value to 3. Other >> platforms do not have this constraint. >> >> Signed-off-by: William Qiu >> Reviewed-by: Hal Feng >> --- >> .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 15 ++++++++++++--- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> index b310069762dd..b6a27171d965 100644 >> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> @@ -26,6 +26,15 @@ allOf: >> const: starfive,jh7110-qspi >> then: >> properties: >> + clocks: >> + maxItems: 3 >> + >> + clock-names: >> + items: >> + - const: ref_clk > > Aww, I liked Mark's suggestions better. > If you are respinning to fix the LKP reported issue w/ ignoring the result > of enabling the clocks, could you chop the _clk off of this one? > > Otherwise, > Reviewed-by: Conor Dooley > > Thanks, > Conor. Hi Conor, Thanks for taking time to review this patch series. About the clock name, I would take Mark's suggestions, and will update it in next version. Best regards, William _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv