From: Samuel Holland <samuel.holland@sifive.com>
To: Prabhakar <prabhakar.csengg@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 4/5] riscv: dts: renesas: rzfive-smarc: Drop dma properties from SSI1 node
Date: Thu, 28 Sep 2023 19:30:46 -0500 [thread overview]
Message-ID: <3d9eb660-e255-4477-a04b-6db8d249a20d@sifive.com> (raw)
In-Reply-To: <20230929000704.53217-5-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Prabhakar,
On 2023-09-28 7:07 PM, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> With DMA enabled audio capture/playback has some echo noise. So for
> now switch to PIO mode until fixed.
Is it really appropriate to work around a Linux software bug with a DT change
like this? Remember, the devicetrees are used by software other than Linux.
Regards,
Samuel
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi b/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi
> index a8573fdfd8b1..85f96e24a96e 100644
> --- a/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi
> +++ b/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi
> @@ -6,3 +6,8 @@
> */
>
> #include <arm64/renesas/rzg2ul-smarc.dtsi>
> +
> +&ssi1 {
> + /delete-property/ dmas;
> + /delete-property/ dma-names;
> +};
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-09-29 0:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 0:06 [PATCH 0/5] Enable peripherals on RZ/Five SMARC EVK Prabhakar
2023-09-29 0:07 ` [PATCH 1/5] riscv: dts: renesas: r9a07g043f: Add L2 cache node Prabhakar
2023-10-03 12:23 ` Geert Uytterhoeven
2023-09-29 0:07 ` [PATCH 2/5] riscv: dts: renesas: r9a07g043f: Add dma-noncoherent property Prabhakar
2023-10-03 12:24 ` Geert Uytterhoeven
2023-09-29 0:07 ` [PATCH 3/5] riscv: dts: renesas: rzfive-smarc: Enable the blocks which were explicitly disabled Prabhakar
2023-10-03 12:28 ` Geert Uytterhoeven
2023-10-03 12:37 ` Lad, Prabhakar
2023-09-29 0:07 ` [PATCH 4/5] riscv: dts: renesas: rzfive-smarc: Drop dma properties from SSI1 node Prabhakar
2023-09-29 0:30 ` Samuel Holland [this message]
2023-09-29 8:35 ` Lad, Prabhakar
2023-09-29 0:07 ` [PATCH 5/5] riscv: configs: defconfig: Enable configs required for RZ/Five SoC Prabhakar
2023-09-29 14:14 ` Conor Dooley
2023-09-29 14:45 ` Lad, Prabhakar
2023-10-03 12:34 ` Geert Uytterhoeven
2023-10-27 22:11 ` Palmer Dabbelt
2023-10-28 21:27 ` Samuel Holland
2023-10-29 8:00 ` Geert Uytterhoeven
2023-11-02 20:20 ` [PATCH 0/5] Enable peripherals on RZ/Five SMARC EVK patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d9eb660-e255-4477-a04b-6db8d249a20d@sifive.com \
--to=samuel.holland@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=magnus.damm@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox