From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 595C7C636D4 for ; Wed, 15 Feb 2023 10:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e1g1cTBDKj2jsiiYqK5fy07xw9P8WhmyynEuFKFbBPU=; b=n8oDXn5hkdUtFA SVM5Qed9uaGfVfGGQaCxw7yreZ/0BuvWP9mMMZ6UEltX2bxCr2T9EjkyUT1bZKUe4b+jQtUt1sizc JWUL3Wmun6G9S0l/qP0ue8STFFaeHy+BVy6LcCTrwvyz9M+N3umcW7tgoKY2P6EEHxWvX8IFhydyn 7+eB5kkpoK+IW1DsESDoQNYK6zQM6xuuZ0GyPDPpprKNTGsDRxXiXOnGj5x1ayNiCPn65GhRI0dKo XTYbM2hxnnWo8VXgA+HctyLfm4tgbDWTZIcxLrGwCxfy4iO7i2YRuXg23PEelknGDA1zApbyvamuk zh8up0iT8IcAjKwBvCjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSEqc-005QWn-3D; Wed, 15 Feb 2023 10:17:10 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSEqX-005QUL-JS for linux-riscv@lists.infradead.org; Wed, 15 Feb 2023 10:17:08 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id C927724DFED; Wed, 15 Feb 2023 18:16:36 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 15 Feb 2023 18:16:37 +0800 Received: from [192.168.120.55] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 15 Feb 2023 18:16:36 +0800 Message-ID: <3ee9b726-10db-5d05-b24a-010c8bf5b59d@starfivetech.com> Date: Wed, 15 Feb 2023 18:16:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 0/3] StarFive's SDIO/eMMC driver support To: Emil Renner Berthing , Ulf Hansson CC: , , , Rob Herring , "Krzysztof Kozlowski" , Jaehoon Chung , References: <20230203081913.81968-1-william.qiu@starfivetech.com> Content-Language: en-US From: William Qiu In-Reply-To: X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230215_021705_975498_E3AB9FF0 X-CRM114-Status: GOOD ( 23.19 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2023/2/15 18:00, Emil Renner Berthing wrote: > On Tue, 14 Feb 2023 at 13:21, Ulf Hansson wrote: >> >> On Fri, 3 Feb 2023 at 09:19, William Qiu wrote: >> > >> > Hi, >> > >> > This patchset adds initial rudimentary support for the StarFive >> > designware mobile storage host controller driver. And this driver will >> > be used in StarFive's VisionFive 2 board. The main purpose of adding >> > this driver is to accommodate the ultra-high speed mode of eMMC. >> > >> > The last patch should be applied after the patchset [1]: >> > [1] https://lore.kernel.org/all/20221220011247.35560-1-hal.feng@starfivetech.com/ >> > >> > Changes since v2: >> > - Wraped commit message according to Linux coding style. >> > - Rephrased the description of the patches. >> > - Changed the description of syscon regsiter. >> > - Dropped redundant properties. >> > >> > The patch series is based on v6.1. >> > >> > William Qiu (3): >> > dt-bindings: mmc: Add StarFive MMC module >> > mmc: starfive: Add sdio/emmc driver support >> > riscv: dts: starfive: Add mmc node >> > >> > .../bindings/mmc/starfive,jh7110-mmc.yaml | 77 ++++++++ >> > MAINTAINERS | 6 + >> > .../jh7110-starfive-visionfive-2.dtsi | 23 +++ >> > arch/riscv/boot/dts/starfive/jh7110.dtsi | 37 ++++ >> > drivers/mmc/host/Kconfig | 10 + >> > drivers/mmc/host/Makefile | 1 + >> > drivers/mmc/host/dw_mmc-starfive.c | 185 ++++++++++++++++++ >> > 7 files changed, 339 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml >> > create mode 100644 drivers/mmc/host/dw_mmc-starfive.c >> > >> >> Patch 1 and patch 2 applied for next, thanks! >> >> Note that I fixed some checkpatch errors/warnings. Next time, please >> run ./scripts/checkpatch.pl before you submit your patches. > > Hi, > > Something here is not right. The bindings document "starfive,sysreg", > but the code is looking for "starfive,syscon". > William, did you test this and run dtbs_check before sending this series? > > /Emil Hi Emil, Sorry about that, it's my negligence that I did dtbs_check without checking the configuration of CONFIG_SOC_STARFIVE. I made a modification in the next version and add binding for all the syscon at the same time. Next time I'll make sure the check is correct.I'm sorry again for this oversight. I'll send v4 patch series today. Best Regards William > >> Kind regards >> Uffe >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv