Re: [PATCH 2/6] virt: bao: Add Bao IPC shared memory driver

From: "João Peixoto" <jpeixoto@osyx.tech>
To: Randy Dunlap <rdunlap@infradead.org>,
	joaopeixoto@osyx.tech, linux-kernel@vger.kernel.org
Cc: ajd@linux.ibm.com, alex@ghiti.fr, aou@eecs.berkeley.edu,
	bagasdotme@gmail.com, catalin.marinas@arm.com,
	conor+dt@kernel.org, corbet@lwn.net, dan.j.williams@intel.com,
	davidmcerdeira@osyx.tech, devicetree@vger.kernel.org,
	dev@kael-k.io, gregkh@linuxfoundation.org, haren@linux.ibm.com,
	heiko@sntech.de, jose@osyx.tech, kever.yang@rock-chips.com,
	krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org,
	maddy@linux.ibm.com, mani@kernel.org, nathan@kernel.org,
	neil.armstrong@linaro.org, palmer@dabbelt.com, pjw@kernel.org,
	prabhakar.mahadev-lad.rj@bp.renesas.com, robh@kernel.org,
	will@kernel.org
Subject: Re: [PATCH 2/6] virt: bao: Add Bao IPC shared memory driver
Date: Fri, 7 Aug 2026 08:42:26 +0100	[thread overview]
Message-ID: <402b7510-d695-45e6-b39b-e0cd2d61657f@osyx.tech> (raw)
In-Reply-To: <df12062e-27ef-454d-b35b-526a88b5c7fa@infradead.org>

On 1/7/26 18:54, Randy Dunlap wrote:
> On 1/7/26 8:28 AM,joaopeixoto@osyx.tech wrote:
>> diff --git a/drivers/virt/bao/ipcshmem/Kconfig b/drivers/virt/bao/ipcshmem/Kconfig
>> new file mode 100644
>> index 000000000000..966bb75aa495
>> --- /dev/null
>> +++ b/drivers/virt/bao/ipcshmem/Kconfig
>> @@ -0,0 +1,8 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +config BAO_SHMEM
>> +	tristate "Bao hypervisor shared memory support"
>> +	help
>> +	This enables support for Bao shared memory communication.
>> +	It allows the kernel to interface with guests running under
>> +	the Bao hypervisor, providing a character device interface
>> +	for exchanging data through dedicated shared-memory regions.
> Please follow Documentation/process/coding-style.rst:
>
> 10) Kconfig configuration files
> -------------------------------
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different.  Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.  Example::
>
>    config AUDIT
> 	bool "Auditing support"
> 	depends on NET
> 	help
> 	  Enable auditing infrastructure that can be used with another
> 	  kernel subsystem, such as SELinux (which requires this for
> 	  logging of avc messages output).  Does not do system-call
> 	  auditing without CONFIG_AUDITSYSCALL.
>
Fixed in v3, the help text is now indented one tab plus two spaces:

   config BAO_SHMEM
       tristate "Bao hypervisor shared memory support"
       help
         This enables support for Bao shared memory communication.
         [...]
         If unsure, say N.

Thanks for catching it.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv