From: William Qiu <william.qiu@starfivetech.com>
To: Conor Dooley <conor@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<devicetree@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>
Subject: Re: [RESEND v6 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc
Date: Thu, 6 Apr 2023 10:20:50 +0800 [thread overview]
Message-ID: <42bdb4e2-bb18-5e4d-f6fb-68564c89efee@starfivetech.com> (raw)
In-Reply-To: <20230405-bullseye-handsaw-5c2e4dab772f@spud>
On 2023/4/6 0:38, Conor Dooley wrote:
> On Mon, Mar 20, 2023 at 03:32:14PM +0800, William Qiu wrote:
>
>> >>> Does not look like you tested the bindings. Please run `make
>> >>> dt_binding_check` (see
>> >>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> >>>
>> >>> ... or your PLL clock controller was not tested.
>> >>>
>> >>> Best regards,
>> >>> Krzysztof
>> >>>
>> >> Hi Krzysztof,
>> >>
>> >> I've already done`make dt_binding_check`, and get no error. So maybe PLL clock controller
>> >> was not tested which I didn't add in this patch series. And PLL clock controller belongs
>> >> to Xingyu Wu, I would tell him.
>> >
>> > What's confusing you do not allow here clock controller.
>
>> I'll add it then.
>
> What's the plan here William?
> Can you sort something out with Xingyu Wu so that the dt-binding is
> added in a complete manner?
> In the meantime, gonna drop this series as "Changes Requested" from
> patchwork.
>
> Cheers,
> Conor.
Hi Conor,
After discussing with Xingyu, I will sort all of it and send a complete
dt-binding today.
Best regards,
William
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-04-06 2:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 5:58 [RESEND v6 0/2] StarFive's SDIO/eMMC driver support William Qiu
2023-03-15 5:58 ` [RESEND v6 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc William Qiu
2023-03-15 19:00 ` Conor Dooley
2023-03-19 12:27 ` Krzysztof Kozlowski
2023-03-20 5:54 ` William Qiu
2023-03-20 6:38 ` Krzysztof Kozlowski
2023-03-20 7:32 ` William Qiu
2023-04-05 16:38 ` Conor Dooley
2023-04-06 2:20 ` William Qiu [this message]
2023-03-19 12:29 ` Krzysztof Kozlowski
2023-03-20 6:00 ` William Qiu
2023-03-20 6:38 ` Krzysztof Kozlowski
2023-03-20 7:31 ` William Qiu
2023-03-15 5:58 ` [RESEND v6 2/2] riscv: dts: starfive: Add syscon node William Qiu
2023-03-15 18:57 ` Conor Dooley
2023-03-15 21:03 ` Emil Renner Berthing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42bdb4e2-bb18-5e4d-f6fb-68564c89efee@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).