From: Xingyu Wu <xingyu.wu@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
<linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Samin Guo <samin.guo@starfivetech.com>,
Guenter Roeck <linux@roeck-us.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: watchdog: Add watchdog for StarFive
Date: Mon, 5 Dec 2022 16:22:13 +0800 [thread overview]
Message-ID: <4327b879-e499-41cd-1846-ce9194efb906@starfivetech.com> (raw)
In-Reply-To: <d6f3d8ac-4fbe-40ca-299b-046973cd0b25@linaro.org>
On 2022/12/5 15:30, Krzysztof Kozlowski wrote:
> On 05/12/2022 04:49, Xingyu Wu wrote:
>> On 2022/12/2 18:46, Krzysztof Kozlowski wrote:
>>> On 02/12/2022 10:39, xingu.wu wrote:
>>>> From: Xingyu Wu <xingyu.wu@starfivetech.com>
>>>>
>>>> Add bindings to describe the watchdog for the StarFive SoCs.
>>>>
>>>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>>>> ---
>>>> .../bindings/watchdog/starfive,wdt.yaml | 77 +++++++++++++++++++
>>>> 1 file changed, 77 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml
>>>> new file mode 100644
>>>> index 000000000000..ece3e80153a0
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml
>>>
>>> Filename should be based on compatible. You do not allow here any other
>>> models... If you intent and you are 100% sure you will grow with new
>>> models, make it maybe a family-based name.
>>
>> First, thank you for your reply. We have some other SoCs like JH7100 would use
>> this watchdog driver, but we now use JH7110 as our main release chip.
>> As you say, should we use "starfive,jh71xx-wdt.yaml" as filename?
>
> starfive,jh7110-wdt.yaml
> I would say because you do not expect any other models (const for
> compatible, not enum)
>
Thanks, I will rename the file in the patches for next version.
Best regards,
Xingyu Wu
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-05 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 9:39 [PATCH v1 0/3] Add watchdog driver for StarFive RISC-V SoCs xingu.wu
2022-12-02 9:39 ` [PATCH v1 1/3] dt-bindings: watchdog: Add watchdog for StarFive xingu.wu
2022-12-02 10:46 ` Krzysztof Kozlowski
2022-12-05 3:49 ` Xingyu Wu
2022-12-05 7:30 ` Krzysztof Kozlowski
2022-12-05 8:22 ` Xingyu Wu [this message]
2022-12-02 9:39 ` [PATCH v1 2/3] drivers: watchdog: Add StarFive Watchdog driver xingu.wu
2022-12-02 15:08 ` Guenter Roeck
2022-12-05 8:08 ` Xingyu Wu
2022-12-02 9:39 ` [PATCH v1 3/3] riscv: dts: starfive: jh7110: Add watchdog node xingu.wu
2022-12-02 10:48 ` Krzysztof Kozlowski
2022-12-05 8:27 ` Xingyu Wu
2022-12-02 11:52 ` [PATCH v1 0/3] Add watchdog driver for StarFive RISC-V SoCs Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4327b879-e499-41cd-1846-ce9194efb906@starfivetech.com \
--to=xingyu.wu@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox