Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Icenowy Zheng <uwu@icenowy.me>, E Shattow <e@freeshell.de>,
	Conor Dooley <conor@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Michael Zhu <michael.zhu@starfivetech.com>,
	Drew Fustini <drew@beagleboard.org>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: riscv: starfive: add xunlong,orangepi-rv
Date: Tue, 25 Nov 2025 08:48:48 +0100	[thread overview]
Message-ID: <489e9d44-fac6-4aa8-b094-ef20196e392b@kernel.org> (raw)
In-Reply-To: <ff1f0e6b95150896136ab31ce13e0a2c7a3a5fe3.camel@icenowy.me>

On 25/11/2025 08:33, Icenowy Zheng wrote:
> 在 2025-11-25星期二的 08:28 +0100，Krzysztof Kozlowski写道：
>> On 24/11/2025 22:59, E Shattow wrote:
>>>
>>> On 11/24/25 05:22, Conor Dooley wrote:
>>>> On Mon, Nov 24, 2025 at 08:28:10AM +0100, Krzysztof Kozlowski
>>>> wrote:
>>>>> On Sun, Nov 23, 2025 at 02:50:44PM -0800, E Shattow wrote:
>>>>>> From: Icenowy Zheng <uwu@icenowy.me>
>>>>>>
>>>>>> Add "xunlong,orangepi-rv" as a StarFive JH7110 SoC-based
>>>>>> board.
>>>>>>
>>>>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>>>>> Signed-off-by: E Shattow <e@freeshell.de>
>>>>>
>>>>> <form letter>
>>>>> This is a friendly reminder during the review process.
>>>>>
>>>>> It looks like you received a tag and forgot to add it.
>>>>
>>>> It's from me, don't resubmit just to add it since it'll be me
>>>> applying
>>>> anyway.
>>>>
>>>
>>> Hi Conor,
>>>
>>> Okay. Yes I'd dropped the tag since the commit message is
>>> appreciably
>>> different, and you would be handling it again anyways. Thanks! And
>>> thank
>>> you Krzysztof for the reminder -E
>>
>>
>> And where did you explain that you dropped the tag because of that?
>> Please read the form letter carefully.
> 
> Well I think there's no clear definition of "the patch has changed
> substantially" here.
> 
> E may think for this such-short patch, the commit message weighs a lot
> and the change to it is significant to the patch (e.g. making the patch
> not clear enough).

You still did not bother to read what we expect. I do not discuss if
this changed significantly or not, although it is obvious that it did
not change and tag should have been retained.

Look again:
<QUOTE>
Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</QUOTE>

Where did you explain that?

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv