From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON
Date: Thu, 30 Dec 2021 05:23:15 +0000 [thread overview]
Message-ID: <4cffedae85c9d847a5285a2f91cb369c48ebe9c9.camel@wdc.com> (raw)
In-Reply-To: <20211229192458.25138-1-lukas.bulwahn@gmail.com>
On Wed, 2021-12-29 at 20:24 +0100, Lukas Bulwahn wrote:
> The config SYSCON never existed in the kernel repository; so, the select of
> that config in ./drivers/soc/canaan/Kconfig has no effect.
>
> Presumably, this was just some mistake, assuming some symmetry in handling
> and naming of configs that simply does not exist.
>
> Remove this useless select of a non-existing config.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/soc/canaan/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
> index 853096b7e84c..2527cf5757ec 100644
> --- a/drivers/soc/canaan/Kconfig
> +++ b/drivers/soc/canaan/Kconfig
> @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
> depends on RISCV && SOC_CANAAN && OF
> default SOC_CANAAN
> select PM
> - select SYSCON
> select MFD_SYSCON
> help
> Canaan Kendryte K210 SoC system controller driver.
My bad :)
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-12-30 5:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 19:24 [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON Lukas Bulwahn
2021-12-30 5:23 ` Damien Le Moal [this message]
2022-01-20 18:17 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cffedae85c9d847a5285a2f91cb369c48ebe9c9.camel@wdc.com \
--to=damien.lemoal@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lukas.bulwahn@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox