From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26939C0219D for ; Mon, 10 Feb 2025 14:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xxw8DF2/hH/G9oJ7h0EqbvkfA1pHeI9fxZPIZGqQH6A=; b=OjKxS0heMr1bOf htAc1iRYW8zpK3F9D4riVzjqi61ynzc9rmd3kKHCfodH/ioH/u75qLZUUWNmijP2gvLa+vOvPQG7P aqeM6oqG9PKB/zfNmhBwm2orIDbptDDpUjZDf73SSJzttASJCjXtQlAz5XgpVqwphrqu/kRniVJPd KA2bUpanvWfkqrgEXPl5KNAsDFQEhSVb+wHHbzEvbd8Ho+IFOS0verSaI72VAxxjzSQZENn293SM9 jZVrTd2Hp8oUl5c7ONHQksx0AtcgpcjSCnd7SAXNhNrkIR3k0XMTSCEaNnI91X0FwU9icQewSAYgu lV+HNAd7n6Bi5PdoZDCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thUll-000000007tM-0FpQ; Mon, 10 Feb 2025 14:28:17 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thUkS-000000007ii-0Fn8; Mon, 10 Feb 2025 14:26:57 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-439350f1a0bso10979585e9.0; Mon, 10 Feb 2025 06:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739197614; x=1739802414; darn=lists.infradead.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=VgraRHso95F81B4DXSSaBLV0feh+tpXbSVAWbEyzHv4=; b=I+Sm/CE4J3XzeV/53sZaKGk6fa8xcc/tqpwCmz+4mni1+0QLnTxnBT4J/n48UWw7SG enNKgYSMv2Ga0rShUQ/8wycWADJNPkp+se4/YvLOdAvICmhOK/rfVZdPeasrhaoZx5v2 PgUhd+giIcbkycTaGoIWNG4xAVLaFwxKW03bD661iPndjeuQM5VOQk1QJhka3f/WKZVs Nyme/UM3ibQLUJS9S+t9JCA00wn0t3IPvxWctqJyED8l4+Aia0JbtKHkGTFQjH+/f3Xb ZrgKvrKoWCcaGEc/LfKktLfdTu9P6VfhT+nFosMEUKiGc3M9ZaujMvShoYSUev+xHkhD hAqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739197614; x=1739802414; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VgraRHso95F81B4DXSSaBLV0feh+tpXbSVAWbEyzHv4=; b=D2khYyly1inB7W3KX/FEmUmzxGXvNTV/SJwDVTGTNPNVmII/jx0PVQbckR+MQ0dTxW O6oNyhjEGWIOQGYTD88x/Yz/T0vaVJq71EP1ObgsajO0gwQUR1wB6ez1JrBywm5quVb5 yWZKx4BSNcbABkWmdq/520BXjx+OYU9siGBR1f7afZsWmf+2IFSZmtS9h02X9wipMWdt +cAayzawoF6XsQ0iwQ3MhmNH/BvRovzsVeyCGt/VlAgRQc0f+EogDhR6OC4F5RX2Z/R8 oAm6/lkfR4Kj+ZXeMCe4JcSq5jBXFlaA1377XTdGjkwkaUadeaMPt8Z93pnF2bFZEY6H bmsg== X-Forwarded-Encrypted: i=1; AJvYcCU6zFG1OobImiWmHfa5AJ8MiOswkdaeBUUdiAZ4ajeQ1O95hCv80/eg+VVy6FHsL3pNEfuwqitIVBcTTEk=@lists.infradead.org, AJvYcCVcgCap/1zyplyWejAy4ITgEL9Na9WyzvkUsa++4liemGbPr1llBS9/v/d/4ztz5RoTiaeddNzbGoHROh+VXtRZ@lists.infradead.org X-Gm-Message-State: AOJu0Yw0YwjQ4NYtUXuvaotgI0Pf/HKM5ZSBMoyZOryKbxcV8r/oIxM1 htaoymvIInn8q8OYja8VcZVKzeAEtafV6A7sKUwgWzDoxo6MUNvu X-Gm-Gg: ASbGncuuyzEtcKMcGSB32eqvQDRml0eTCDPcXHxAYAgAvm5eUGjexOwyMoOxBzAKRfU r7O3w1bbxWHXl5Jw1lvxlVn479wsEKwzsHrpJmPVF58LXmOXA8WVnJdEdHmkagiUDMuL/6T6Rvm bN6aVze3UiZiJSGt0JIoCEtEgvn16OzkpkuY96VwuMN+x7XPX7FkyQqaRquuUDB1/DE1JKfUWt2 wnr3ZhE4YyOMq4TmM2YbD20J/P+mqUfgGEdxMilCbtoejXrFycx5fxfCfxZAEeui7iIuTLbSLoJ 7vDBa77t2XTrd90Nxm5hxn8ejWSlxrBV X-Google-Smtp-Source: AGHT+IEYNgbdZHkRJU1UDHCBy9QezY1XmzJ1vuM2419I++2sRPB2lMGddbBAfie6JehAjN/mVPK+vg== X-Received: by 2002:a05:600c:5351:b0:439:3159:c33d with SMTP id 5b1f17b1804b1-4393159c5abmr70934525e9.13.1739197614251; Mon, 10 Feb 2025 06:26:54 -0800 (PST) Received: from giga-mm.home ([2a02:1210:861b:6f00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4393f202721sm49032005e9.21.2025.02.10.06.26.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 06:26:53 -0800 (PST) Message-ID: <4d171a4fdf7ce9bfbe6352b36d6b6791584f86c4.camel@gmail.com> Subject: Re: [PATCH 02/10] riscv: dts: sophgo: cv18xx: Split into CPU core and peripheral parts From: Alexander Sverdlin To: Krzysztof Kozlowski , soc@lists.linux.dev Cc: Inochi Amaoto , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Mon, 10 Feb 2025 15:26:52 +0100 In-Reply-To: References: <20250209220646.1090868-1-alexander.sverdlin@gmail.com> <20250209220646.1090868-3-alexander.sverdlin@gmail.com> User-Agent: Evolution 3.54.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_062656_101776_0719E282 X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Krzysztof! On Mon, 2025-02-10 at 09:43 +0100, Krzysztof Kozlowski wrote: > > diff --git a/arch/riscv/boot/dts/sophgo/cv18xx-periph.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx-periph.dtsi > > new file mode 100644 > > index 000000000000..53834b0658b2 > > --- /dev/null > > +++ b/arch/riscv/boot/dts/sophgo/cv18xx-periph.dtsi > > @@ -0,0 +1,313 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +/* > > + * Copyright (C) 2023 Jisheng Zhang > > + * Copyright (C) 2023 Inochi Amaoto > > + */ > > + > > +#include > > +#include > > +#include > > + > > +/ { > > + osc: oscillator { > > + compatible = "fixed-clock"; > > I really doubt that external oscillator is a peripheral. This is either > part of board or the SoC. > > > > + clock-output-names = "osc_25m"; > > + #clock-cells = <0>; > > + }; > > + > > + soc { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > No, override by phandle/label instead of duplicating SoC. Is this one critical? Otherwise I struggle in v2 to both keep SOC_PERIPHERAL_IRQ() in [a new] cv18xx-cpu.dtsi and reference &soc from cv18xx-cpu.dtsi. It's kind of circular-dependency. -- Alexander Sverdlin. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv