From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7378BC87FCF for ; Fri, 25 Jul 2025 11:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DXu7kJCRXy2/FVmaF8yiHXn4tm4VZfheQ2pLSX3Gy2g=; b=YKWKCLsFtY2uYv 4bBb4bIiehNk2DrIVk7g7yM3Ex3MyqiJPnU2rqfVf40xQVp/bv6BJuvCJkJeIDM44usYeFVJpkl1l 2WPDsF9gqd6+R8TnZIpejOdczbqDLdEjjUoIFnPnHeXv4uKkd9ACtKjmZuuLW3KaZknP3bog331KF R3zYzBxRY4NTtlx4uTdQ6ebBPuQYGHyAbnAlNDgmXFOTDwi4uZxBiaOkux9DgogC7nNu8tFYlnubN u3GBWbWGbhRxDbA+ySpm+Fx3MHnW+knzzMtSV1FnyEM/EJDVXFKiVLjGgVEFOpC9t2mqQ5P5blurP eKQhH9PgCtJrSn/XXUWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ufGkQ-00000009jc0-0RE6; Fri, 25 Jul 2025 11:37:58 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ufGHs-00000009fnj-0ag5 for linux-riscv@lists.infradead.org; Fri, 25 Jul 2025 11:08:29 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-adb2bd27d8bso12653666b.1 for ; Fri, 25 Jul 2025 04:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753441706; x=1754046506; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Uw5xYz9ljVloUXuYhdtWs7nMIXFU+Uc/d7Zb4IlFZdg=; b=U5CqOdwBQM27EWg2r94M97EY45FYJfJgE9txXkXEhMnWsUPYaZRAaSnphyh++mFc8E g0OeFTBTtiAaL6xXuUqWOt5bGWQq7a7QKk6w0KEKBfJFFKNvu3RmoPHCHi0Gl0hDp4CI K9hH4yFELzhCTGav2CBOlFkORJNd+3rh1Qm8lSw7F7Gciv9p7O/01g0FPzUoZBQ7PeUu VbA33/OIvWKR1DC0ia2BfQja3YrOCGF58KKa883P/K3COKMEp/iztlahtVQJc+LCQ39/ nOfV6zzIKnPJ56w0AMSKgxoIttU+KmZeIKdEVMVqZqqQhG1pVlV78OCBnTQkNg5W/cv2 qDgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753441706; x=1754046506; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uw5xYz9ljVloUXuYhdtWs7nMIXFU+Uc/d7Zb4IlFZdg=; b=lv9gxnzmd+h9Sno/Fj4FwTXpyVK6rpym+B/pPltSD5JvsKyGBD8jfxtclvkr3bxYVA AVcCZNfN5ExshyWV5lCaReJikSCfM8bTEtgx8EEXBH60Mg23/9Tne0LTQy3szOsH7jkQ YidIGYjZ94VxFinrt8q4AB3cWwZIiCtcVxk6nb9/UVDAZwS9rKNCl6xcoB7El9FN/Nz8 qFM3pWmGNR58EjwU2szwtzZJMAa08F2QAvIDe3vixMQkYGW0oQkSFHQSDce1jN9o0Z2R p4vXqzYp823XIALaAV1qwFAqMPe/pZeUf62t1Bu7k1v0WWNsIxX9Bhs4xFc2I6Wx01Ds eD8Q== X-Forwarded-Encrypted: i=1; AJvYcCXMjuGdjduIVjWIk6Pj43w4KiglC//pv455jr1C9a2tmQNXaRCUaxj2XgaxGSz8CIlk8OocIrmarV/ETQ==@lists.infradead.org X-Gm-Message-State: AOJu0YzU0ZZSRstZq+mfaLWnAFUzL+Dn8EVN7YjgKWyPDbiKb17rpeiJ Dp7F6d7s2SGECPqJiN5AXX/wP3V5RE9IcqGhp9xBbQe1wO01+li95zMiIW8WmnKsyic= X-Gm-Gg: ASbGncuCh730GyTsuOeN5DjOkMFLSx9OPedMpytHqMaznxvjDZ6EQ+Q8cyoWVEW+TIM WsD8a4P9oRmm5NaF4jHP8mo4bFkX/740+55KEQA/QwPtn6k2/HV7rqL/MtCW2KORCga9eyTaeFk 1v3fkiphG2V/xp7nQJuSnLD8806xnic+jTtiPlZRYb/fSYmLLczfiRmSvk5KNf24AasO2yTGB+L Lodvq0bXvdvgjP9J0M3D0L7wjSqTDjauo+bkrf5Awldj6uFPAEgD5irCsU8PJQgCSfzJcnYNoCY 1q1wA87kcSdwKfLF7iiNK80LiOiigV1RIXJobhns46e+xgZRD8u1WVIHwGUV20avxMImq3lO+TH 8E1XU3086ks16ROv12KIdgVKOeEY9I20TFIh9ciJYjsLYk6eSZ7Oo X-Google-Smtp-Source: AGHT+IGPX2ebFd1G1UY4hjy4nK32/r3TZiGosjelo1wUHJ7aU9RYrlPYLD6uyjWm58/GD1RzAlB50w== X-Received: by 2002:a17:906:b894:b0:af6:32b3:2674 with SMTP id a640c23a62f3a-af632b331e2mr3687066b.0.1753441706435; Fri, 25 Jul 2025 04:08:26 -0700 (PDT) Received: from [192.168.1.29] ([178.197.203.90]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af47f44eaf5sm253765966b.80.2025.07.25.04.08.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jul 2025 04:08:25 -0700 (PDT) Message-ID: <4d79c8dd-c5fb-442c-ac65-37e7176b0cdd@linaro.org> Date: Fri, 25 Jul 2025 13:08:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/4] dt-bindings: gpu: img,powervr-rogue: Add TH1520 GPU compatible To: Matt Coster , Michal Wilczynski Cc: Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Philipp Zabel , Frank Binns , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Ulf Hansson , Marek Szyprowski , Drew Fustini , "linux-riscv@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Bartosz Golaszewski References: <20250724-apr_14_for_sending-v8-0-0714bef83c59@samsung.com> <20250724-apr_14_for_sending-v8-2-0714bef83c59@samsung.com> <20250725-gainful-saluki-of-mathematics-3c0dd0@kuoka> <4461a785-b593-429e-b436-44cd2f1c96eb@imgtec.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92Vcmzn/jaEBcq yT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbThLsSN1AuyP8wF KChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH5lSCjhP4VXiG q5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpFc1D/9NV/zIWB G1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzePt/SvC0RhQXNj XKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60RtThnhKc2kLI zd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7qVT41xdJ6KqQM NGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZv+PKIVf+zFKu h0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1qwom6QbU06ltb vJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHpcwzYbmi/Et7T 2+47PN9NZAOyb771QoVr8A== In-Reply-To: <4461a785-b593-429e-b436-44cd2f1c96eb@imgtec.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250725_040828_192950_FEF9A659 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 25/07/2025 11:00, Matt Coster wrote: > On 25/07/2025 07:59, Krzysztof Kozlowski wrote: >> On Thu, Jul 24, 2025 at 04:18:59PM +0200, Michal Wilczynski wrote: >>> Update the img,powervr-rogue.yaml to include the T-HEAD TH1520 SoC's >>> specific GPU compatible string. >>> >>> The thead,th1520-gpu compatible, along with its full chain >>> img,img-bxm-4-64, and img,img-rogue, is added to the >>> list of recognized GPU types. >>> >>> While the BXM-4-64 GPU IP is designed with two distinct power domains, >>> the TH1520 SoC integrates it with only a single, unified power gate that >>> is controllable by the kernel. >>> >>> To model this reality correctly while keeping the binding accurate for >>> other devices, add conditional constraints to the `allOf` section: >>> - An if block for thead,th1520-gpu enforces a maximum of one >>> power domain and disallows the power-domain-names property. >> >> Why? >> >> This solves nothing, because you did not change the meaning of power >> domain entry. > > Hi Krzysztof, > > Just to clarify, is this an issue that can be resolved by documenting > the semantics of ">=1 power domains with names" vs "1 unnamed power > domain" in the binding file? Or are you suggesting an alternative method > of encoding this information in devicetree? Currently, through power-domain names, the first entry in power domains is the 'a' domain. We usually prefer this to be explicit - listing items - but here, probably due to obviousness of names A and B, it did not happen. Disallowing power-domain names does magically change existing binding. I think you should list the power-domains items explicitly for each variant (see any of my other standard examples how this is done, e.g. clock controllers). Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv