From: William Qiu <william.qiu@starfivetech.com>
To: Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org,
"Emil Renner Berthing" <kernel@esmil.dk>,
"Rob Herring" <robh+dt@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Hal Feng" <hal.feng@starfivetech.com>
Subject: Re: [RFC v4 4/4] riscv: dts: starfive: jh7100: Add PWM node and pins configuration
Date: Tue, 29 Aug 2023 17:41:21 +0800 [thread overview]
Message-ID: <503bbb09-2886-9dbb-808a-65422bab712c@starfivetech.com> (raw)
In-Reply-To: <CAJM55Z-Ab1DAQyQC9TRFFBidus6wCRns9RQjx-iyYyNK1e-e6A@mail.gmail.com>
On 2023/8/29 17:38, Emil Renner Berthing wrote:
> On Fri, 25 Aug 2023 at 10:16, William Qiu <william.qiu@starfivetech.com> wrote:
>> Add StarFive JH7100 PWM controller node and add PWM pins configuration
>> on VisionFive 2 board.
>
> Hi William,
>
> This is the VisionFive V1 board right?
>
> /Emil
>
Hi Emil,
Yes, it's VisionFive V1, I wrote it wrong.
B.R.
William
>> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
>> ---
>> .../boot/dts/starfive/jh7100-common.dtsi | 24 +++++++++++++++++++
>> arch/riscv/boot/dts/starfive/jh7100.dtsi | 9 +++++++
>> 2 files changed, 33 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7100-common.dtsi b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
>> index b93ce351a90f..746867b882b0 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
>> @@ -84,6 +84,24 @@ GPO_I2C2_PAD_SDA_OEN,
>> };
>> };
>>
>> + pwm_pins: pwm-0 {
>> + pwm-pins {
>> + pinmux = <GPIOMUX(7,
>> + GPO_PWM_PAD_OUT_BIT0,
>> + GPO_PWM_PAD_OE_N_BIT0,
>> + GPI_NONE)>,
>> + <GPIOMUX(5,
>> + GPO_PWM_PAD_OUT_BIT1,
>> + GPO_PWM_PAD_OE_N_BIT1,
>> + GPI_NONE)>;
>> + bias-disable;
>> + drive-strength = <35>;
>> + input-disable;
>> + input-schmitt-disable;
>> + slew-rate = <0>;
>> + };
>> + };
>> +
>> uart3_pins: uart3-0 {
>> rx-pins {
>> pinmux = <GPIOMUX(13, GPO_LOW, GPO_DISABLE,
>> @@ -154,6 +172,12 @@ &osc_aud {
>> clock-frequency = <27000000>;
>> };
>>
>> +&ptc {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pwm_pins>;
>> + status = "okay";
>> +};
>> +
>> &uart3 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&uart3_pins>;
>> diff --git a/arch/riscv/boot/dts/starfive/jh7100.dtsi b/arch/riscv/boot/dts/starfive/jh7100.dtsi
>> index 4218621ea3b9..7f5bb19e636e 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7100.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7100.dtsi
>> @@ -248,5 +248,14 @@ watchdog@12480000 {
>> resets = <&rstgen JH7100_RSTN_WDTIMER_APB>,
>> <&rstgen JH7100_RSTN_WDT>;
>> };
>> +
>> + ptc: pwm@12490000 {
>> + compatible = "starfive,jh7100-pwm";
>> + reg = <0x0 0x12490000 0x0 0x10000>;
>> + clocks = <&clkgen JH7100_CLK_PWM_APB>;
>> + resets = <&rstgen JH7100_RSTN_PWM_APB>;
>> + #pwm-cells = <3>;
>> + status = "disabled";
>> + };
>> };
>> };
>> --
>> 2.34.1
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-08-29 9:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 8:13 [RFC v4 0/4] StarFive's Pulse Width Modulation driver support William Qiu
2023-08-25 8:13 ` [RFC v4 1/4] dt-bindings: pwm: Add StarFive PWM module William Qiu
2023-08-25 8:13 ` [RFC v4 2/4] pwm: starfive: Add PWM driver support William Qiu
2023-09-12 15:04 ` Emil Renner Berthing
2023-09-13 10:57 ` William Qiu
2023-08-25 8:13 ` [RFC v4 3/4] riscv: dts: starfive: jh7110: Add PWM node and pins configuration William Qiu
2023-08-25 8:13 ` [RFC v4 4/4] riscv: dts: starfive: jh7100: " William Qiu
2023-08-29 7:44 ` Hal Feng
2023-08-29 9:38 ` Emil Renner Berthing
2023-08-29 9:41 ` William Qiu [this message]
2023-08-25 15:06 ` [RFC v4 0/4] StarFive's Pulse Width Modulation driver support Conor Dooley
2023-08-28 7:12 ` Hal Feng
2023-08-28 7:16 ` Krzysztof Kozlowski
2023-08-28 7:47 ` Hal Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503bbb09-2886-9dbb-808a-65422bab712c@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox