From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84205C27C79 for ; Wed, 19 Jun 2024 13:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VSfIdoR+QiK+IAOrewwe4RZKrjLP9j+voqm//pDkS18=; b=i7vF9T64c3FZeW 4pp/2LU533NrhByfS0f6/XbJBifv+s6SKrqqwTdxH/ebHQ5tkil65u5vq64FDDJO9S0XAidO6OK3Z TD3FI8HVEIeKnjTaThsaIX1xu1NTxZMH9x7EKffJ950HZgu/A4KgzbDjPCuY78sCvIjcdGdjsVsSW GHpBL+FwUHXU4f/6aoplHy4JMBJyNBIyzuFKuXR8rRWgDNGLXtAXJ9QN4gte6hxhI2J7Yx+YNnYmh PidQSG4LeamFf1IjFml9z+7r9GSQyObSz9MTUZbzu0zULmyQ8LYiWztwANll7mPwkQu1Tg65hZDYt dR8RpyFeRLgjY00xiIqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJva6-00000001MDf-2jeY; Wed, 19 Jun 2024 13:42:34 +0000 Received: from mgamail.intel.com ([198.175.65.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJva3-00000001MCE-04iJ for linux-riscv@lists.infradead.org; Wed, 19 Jun 2024 13:42:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718804551; x=1750340551; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=9r5Ceks4s8d+tHDH0o9Hm+jP9uqytN7Zxvu/USoXgjg=; b=UzfYs/eZO+8QLLtrSZ+XM9DCbFSzYgJwWaXbfD+vDRetp98mwIRLKRIx yh0UOJ8kG4Gcd/mX/K1eqCUVfvCZ+4FCwRtjNUWg+YWO67ugaj9Ny+WCc F9ouAJU4lm+djmpiIHSIALwrjvzBVB71NuhSglk56ijAdTCdhqv11d8vh D7hNS+sOoHvOrHxwwBmC5P7pDBMPQqd1Z44gka/SUuFg20Uf4kHvzja/M ZFVwb57+Cm5YWEkFd/EScpkRhFPGXBogo7blBer0eBpjNp9eW+tjLI0fh tXtrammZiZGTVfbJsHsDHg8jd7MZprrElGtwkZeRZ9K5TjQ5e3emykNVb g==; X-CSE-ConnectionGUID: YMN+7CzfSoiZnzaCZ9gdLw== X-CSE-MsgGUID: BKCZWE9tToiHcM8sOxriBA== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="15577288" X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="15577288" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 06:42:23 -0700 X-CSE-ConnectionGUID: zwlqVW2gR3mlObMXteFd9A== X-CSE-MsgGUID: s15hi+FUQGeDZBs4Rf3zLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="42603106" Received: from marquiz-s-2.fi.intel.com (HELO [10.237.72.58]) ([10.237.72.58]) by orviesa008.jf.intel.com with ESMTP; 19 Jun 2024 06:42:18 -0700 Message-ID: <51c1faeb-c54d-4ee4-b913-50aed7a0909c@linux.intel.com> Date: Wed, 19 Jun 2024 16:42:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dt-bindings: i2c: dw: Document compatible thead,th1520-i2c To: Krzysztof Kozlowski , Thomas Bonnefille , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jisheng Zhang , Guo Ren , Fu Wei , Drew Fustini , Emil Renner Berthing , Conor Dooley Cc: Palmer Dabbelt , Albert Ou , Paul Walmsley , Thomas Petazzoni , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Conor Dooley References: <20240618-i2c-th1520-v3-0-3042590a16b1@bootlin.com> <20240618-i2c-th1520-v3-1-3042590a16b1@bootlin.com> Content-Language: en-US From: Jarkko Nikula In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240619_064231_170692_EBAAA747 X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 6/19/24 10:39 AM, Krzysztof Kozlowski wrote: > On 19/06/2024 08:40, Jarkko Nikula wrote: >> Hi >> >> On 6/18/24 10:42 AM, Thomas Bonnefille wrote: >>> Add documentation for compatible string thead,th1520-i2c which can be >>> used specifically for the TH1520 SoC. >>> >>> Signed-off-by: Thomas Bonnefille >>> Acked-by: Conor Dooley >>> --- >>> Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml >>> index d9293c57f573..60035a787e5c 100644 >>> --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml >>> +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml >>> @@ -33,6 +33,10 @@ properties: >>> - const: snps,designware-i2c >>> - description: Baikal-T1 SoC System I2C controller >>> const: baikal,bt1-sys-i2c >>> + - description: T-HEAD TH1520 SoCs I2C controller >>> + items: >>> + - const: thead,th1520-i2c >>> + - const: snps,designware-i2c >>> >> >> Your comment below makes me thinking is this change needed? So is it >> enough to specify "snps,designware-i2c" for the compatible string in >> patch 2/3? > > SoC specific compatible is always required (see writing bindings doc). > Fair enough. Reviewed-by: Jarkko Nikula _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv