From: Heiko Stuebner <heiko@sntech.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: palmer@dabbelt.com, paul.walmsley@sifive.com,
aou@eecs.berkeley.edu, herbert@gondor.apana.org.au,
davem@davemloft.net, conor.dooley@microchip.com,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, christoph.muellner@vrull.eu,
Heiko Stuebner <heiko.stuebner@vrull.eu>
Subject: Re: [PATCH v5 0/4] Implement GCM ghash using Zbc and Zbkb extensions
Date: Mon, 10 Jul 2023 11:44:56 +0200 [thread overview]
Message-ID: <5381895.Sb9uPGUboI@phil> (raw)
In-Reply-To: <20230613030216.GC883@sol.localdomain>
Hi Eric,
Am Dienstag, 13. Juni 2023, 05:02:16 CEST schrieb Eric Biggers:
> Hi Heiko,
>
> On Mon, Jun 12, 2023 at 11:04:38PM +0200, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@vrull.eu>
> >
> > This was originally part of my vector crypto series, but was part
> > of a separate openssl merge request implementing GCM ghash as using
> > non-vector extensions.
> >
> > As that pull-request
> > https://github.com/openssl/openssl/pull/20078
> > got merged recently into openssl, we could also check if this could
> > go into the kernel as well and provide a base for further accelerated
> > cryptographic support.
>
> I'm still a bit skeptical of the usefulness of a standalone "ghash"
> implementation, when in practice it will only be used as part of "gcm(aes)".
> Directly implementing "gcm(aes)" (instead of relying on crypto/gcm.c to compose
> "ghash" and "ctr(aes)") also allows some performance optimizations.
>
> I asked about this on v4
> (https://lore.kernel.org/linux-crypto/ZCSG71bRuTzVutdm@gmail.com/),
> but I didn't receive a response.
>
> Any thoughts on this?
somehow I always seem to overlook this when adapting the series :-(
I guess for me the main gcm was always a stepping stone to get
started and extend later. This is my first rodeo with crypto stuff
in the kernel, so this looks like a manageable chunk and as can be
seen by the discussion we had about licensing brings enough topics
on its own :-) .
Heiko
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2023-07-10 9:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 21:04 [PATCH v5 0/4] Implement GCM ghash using Zbc and Zbkb extensions Heiko Stuebner
2023-06-12 21:04 ` [PATCH v5 1/4] RISC-V: add Zbc extension detection Heiko Stuebner
2023-06-12 21:31 ` Conor Dooley
2023-06-20 19:09 ` Palmer Dabbelt
2023-06-20 19:12 ` Conor Dooley
2023-06-20 19:37 ` Jeff Law
2023-06-20 19:42 ` Palmer Dabbelt
2023-06-12 21:04 ` [PATCH v5 2/4] RISC-V: add Zbkb " Heiko Stuebner
2023-06-12 21:33 ` Conor Dooley
2023-06-12 21:04 ` [PATCH v5 3/4] RISC-V: hook new crypto subdir into build-system Heiko Stuebner
2023-06-13 16:54 ` Conor Dooley
2023-06-12 21:04 ` [PATCH v5 4/4] RISC-V: crypto: add accelerated GCM GHASH implementation Heiko Stuebner
2023-06-13 3:10 ` Eric Biggers
2023-06-13 8:00 ` Heiko Stübner
2023-06-13 19:01 ` Eric Biggers
2023-06-16 10:34 ` Herbert Xu
2023-07-07 17:57 ` Heiko Stübner
2023-06-13 3:02 ` [PATCH v5 0/4] Implement GCM ghash using Zbc and Zbkb extensions Eric Biggers
2023-07-10 9:44 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5381895.Sb9uPGUboI@phil \
--to=heiko@sntech.de \
--cc=aou@eecs.berkeley.edu \
--cc=christoph.muellner@vrull.eu \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=heiko.stuebner@vrull.eu \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox