Re: [PATCH v2 11/16] perf parse-events: Improve error message for bad numbers

Arnaldo Carvalho de Melo
2024-04-27T01:36:11Z

On Mon, Apr 15, 2024 at 11:15:27PM -0700, Ian Rogers wrote:
> Use the error handler from the parse_state to give a more informative
> error message.
>
> Before:
> ```
> $ perf stat -e 'cycles/period=99999999999999999999/' true
> event syntax error: 'cycles/period=99999999999999999999/'
> \___ parser error
> Run 'perf list' for a list of valid events
>
> Usage: perf stat [<options>] [<command>]
>
> -e, --event <event> event selector. use 'perf list' to list available events
> ```
>
> After:
> ```
> $ perf stat -e 'cycles/period=99999999999999999999/' true
> event syntax error: 'cycles/period=99999999999999999999/'
> \___ parser error
>

This ended up in perf-tools-next, will have to look at what this problem
is:

9 11.46 amazonlinux:2 : FAIL gcc version 7.3.1 20180712 (Red Hat 7.3.1-17) (GCC)
yy_size_t parse_events_get_leng (yyscan_t yyscanner );
^~~~~~~~~~~~~~~~~~~~~
util/parse-events.l:22:5: note: previous declaration of 'parse_events_get_leng' was here
int parse_events_get_leng(yyscan_t yyscanner);
^~~~~~~~~~~~~~~~~~~~~
yy_size_t parse_events_get_leng (yyscan_t yyscanner)
^~~~~~~~~~~~~~~~~~~~~
util/parse-events.l:22:5: note: previous declaration of 'parse_events_get_leng' was here
int parse_events_get_leng(yyscan_t yyscanner);
^~~~~~~~~~~~~~~~~~~~~
make[3]: *** [util] Error 2

Unsure if this will appear on the radar on other distros, maybe this is
just something that pops up with older distros...

Ran out of time today...

- Arnaldo