Re: [RFC PATCH v2 2/9] dt-bindings: soc: microchip: document the simple-mfd syscon on PolarFire SoC

Conor Dooley
2025-03-25T16:16:46Z

[-- Attachment #1.1: Type: text/plain, Size: 1847 bytes --]

On Tue, Mar 25, 2025 at 09:13:22AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Mar 21, 2025 at 05:22:35PM +0000, Conor Dooley wrote:
> > +title: Microchip PolarFire SoC Microprocessor Subsystem (MSS) sysreg register region
> > +
> > +maintainers:
> > + - Conor Dooley <conor.dooley@microchip.com>
> > +
> > +description:
> > + An wide assortment of registers that control elements of the MSS on PolarFire
> > + SoC, including pinmuxing, resets and clocks among others.
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - const: microchip,mpfs-mss-top-sysreg
> > + - const: syscon
> > + - const: simple-mfd
>
> You need to list the children if you use simple-mfd. Commit msg
> mentioned clock controller, so where is it?

I don't think a child node is required here, there's not enough
clock-related properties for it to require one. However, I think you're
correct about missing properties in a general sense - there should be a
#clock-cells here and a clocks/clock-names too.
The reason there aren't is because the existing driver (that binds to
microchip,mpfs-clkcfg) looks this node up by compatible, and implements
the clock parent for this node etc. Obviously that's not an excuse to
leave the properties out, so I'll add them even though they're going to
end up ignored.

> > + reg:
> > + maxItems: 1
> > +
> > + '#reset-cells':
> > + description:
> > + The AHB/AXI peripherals on the PolarFire SoC have reset support, so
> > + from CLK_ENVM to CLK_CFM. The reset consumer should specify the
> > + desired peripheral via the clock ID in its "resets" phandle cell.
> > + See include/dt-bindings/clock/microchip,mpfs-clock.h for the full list
> > + of PolarFire clock/reset IDs.
> > + const: 1
>
> Best regards,
> Krzysztof
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]