Re: [PATCH v2] rust: pwm: Add UnregisteredChip wrapper around Chip

From: Michal Wilczynski <m.wilczynski@samsung.com>
To: "Markus Probst" <markus.probst@posteo.de>,
	"Uwe Kleine-König" <ukleinek@kernel.org>
Cc: linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	"Drew Fustini" <fustini@kernel.org>,
	"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>
Subject: Re: [PATCH v2] rust: pwm: Add UnregisteredChip wrapper around Chip
Date: Tue, 9 Dec 2025 14:41:29 +0100	[thread overview]
Message-ID: <5a742181-dff6-4073-ada0-342298da63b6@samsung.com> (raw)
In-Reply-To: <a66b337528d700ae92d7940a04c59206e06a8495.camel@posteo.de>

On 12/9/25 13:26, Markus Probst wrote:
> On Tue, 2025-12-09 at 09:08 +0100, Uwe Kleine-König wrote:
>> On Sun, Dec 07, 2025 at 11:16:59PM +0100, Michal Wilczynski wrote:
>>> On 12/2/25 19:17, Markus Probst wrote:
>> What does "not able to successfully compile drivers/pwm/pwm_th1520.rs"
>> mean? You were unable to find a .config that included CONFIG_PWM_TH1520,
>> or you got a compiler error? If it's the latter, ...
>>
>>> I suspect your kernel configuration is missing CONFIG_COMMON_CLK.
>>
>> ... are we missing a dependency for the driver?
> I got a compiler error. Enabling CONFIG_COMMON_CLK indeed fixes it.
> 
> Without it:
>   CLIPPY     drivers/pwm/pwm_th1520.o
> error[E0432]: unresolved import `kernel::clk::Clk`
>   --> drivers/pwm/pwm_th1520.rs:26:5
>    |
> 26 |     clk::Clk,
>    |     ^^^^^^^^ no `Clk` in `clk`
> 
> error: aborting due to 1 previous error
> 
> For more information about this error, try `rustc --explain E0432`.
> make[4]: *** [scripts/Makefile.build:354: drivers/pwm/pwm_th1520.o]
> Error 1
> make[3]: *** [scripts/Makefile.build:556: drivers/pwm] Error 2
> make[2]: *** [scripts/Makefile.build:556: drivers] Error 2
> make[1]: *** [/home/markustieger/build/synology/linux-
> upstream/Makefile:2010: .] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
> 
> A simple fix would be to add "depends on COMMON_CLK" in
> drivers/pwm/Kconfig for PWM_TH1520.

While at it I think we should also add dependency on ARCH_THEAD |
COMPILE_TEST as well as HAS_IOMEM in my opinion. I think some of those
dependencies were lost when we were iterating on the patchset for some
reason, can't recall when exactly.

If you plan to send a patch include those as well. Otherwise let me know
and I send a patch.

> 
> Thanks
> - Markus Probst
Best regards,
-- 
Michal Wilczynski <m.wilczynski@samsung.com>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv