From: "Wu, Fei" <fei2.wu@intel.com>
To: Alexandre Ghiti <alex@ghiti.fr>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<guoren@kernel.org>, <jszhang@kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: Fix definition of _PAGE_NOCACHE_THEAD
Date: Tue, 27 Feb 2024 20:47:18 +0800 [thread overview]
Message-ID: <5c030391-d8df-45aa-b4e2-73c45fbd1d97@intel.com> (raw)
In-Reply-To: <20db97b7-6225-42a4-9f2a-b926aa26b7aa@ghiti.fr>
On 2/27/2024 8:44 PM, Alexandre Ghiti wrote:
> Hi Fei,
>
> On 27/02/2024 13:44, Fei Wu wrote:
>> _PAGE_NOCACHE_THEAD is not used but the definition is wrong.
>>
>> Signed-off-by: Fei Wu <fei2.wu@intel.com>
>> ---
>> arch/riscv/include/asm/pgtable-64.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/include/asm/pgtable-64.h
>> b/arch/riscv/include/asm/pgtable-64.h
>> index b42017d76924..b99bd66107a6 100644
>> --- a/arch/riscv/include/asm/pgtable-64.h
>> +++ b/arch/riscv/include/asm/pgtable-64.h
>> @@ -136,7 +136,7 @@ enum napot_cont_order {
>> * 10010 - IO Strongly-ordered, Non-cacheable, Non-bufferable,
>> Shareable, Non-trustable
>> */
>> #define _PAGE_PMA_THEAD ((1UL << 62) | (1UL << 61) | (1UL <<
>> 60))
>> -#define _PAGE_NOCACHE_THEAD ((1UL < 61) | (1UL << 60))
>> +#define _PAGE_NOCACHE_THEAD ((1UL << 61) | (1UL << 60))
>> #define _PAGE_IO_THEAD ((1UL << 63) | (1UL << 60))
>> #define _PAGE_MTMASK_THEAD (_PAGE_PMA_THEAD | _PAGE_IO_THEAD |
>> (1UL << 59))
>>
>
>
> This fix is already in -fixes:
> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?id=c21f014818600ae017f97ee087e7c136b1916aa7
>
Thank you Alex, got it.
Fei.
> Thanks,
>
> Alex
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2024-02-27 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 12:44 [PATCH] riscv: Fix definition of _PAGE_NOCACHE_THEAD Fei Wu
2024-02-27 12:44 ` Alexandre Ghiti
2024-02-27 12:47 ` Wu, Fei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c030391-d8df-45aa-b4e2-73c45fbd1d97@intel.com \
--to=fei2.wu@intel.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox