From: Krzysztof Kozlowski <krzk@kernel.org>
To: Troy Mitchell <troymitchell988@gmail.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] riscv: spacemit: add i2c support to K1 SoC
Date: Mon, 25 Nov 2024 09:06:02 +0100 [thread overview]
Message-ID: <5d69e1db-2ec5-445d-9336-9345c918722a@kernel.org> (raw)
In-Reply-To: <20241125-k1-i2c-master-v4-0-0f3d5886336b@gmail.com>
On 25/11/2024 07:49, Troy Mitchell wrote:
> Hi all,
>
> This patch implements I2C driver for the SpacemiT K1 SoC,
> providing basic support for I2C read/write communication which
> compatible with standard I2C bus specifications.
>
> In this version, the driver defaults to use fast-speed-mode and
> interrupts for transmission, and does not support DMA, high-speed mode, or FIFO.
>
> The docs of I2C can be found here, in chapter 16.1 I2C [1]
>
> Link: https://developer.spacemit.com/documentation?token=Rn9Kw3iFHirAMgkIpTAcV2Arnkf#part5 [1]
> ---
> Change in v4:
> - Patch #1:
> - Change the default value of clock-frequency from 100000 to
> 400000. This is to correspond to the driver's default value.
> - Drop the minimum of clock-frequency
> - Modify the description of clock-frequency
Explain why do you request re-review.
<form letter>
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
If a tag was not added on purpose, please state why and what changed.
</form letter>
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-11-25 8:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 6:49 [PATCH v4 0/2] riscv: spacemit: add i2c support to K1 SoC Troy Mitchell
2024-11-25 6:49 ` [PATCH v4 1/2] dt-bindings: i2c: spacemit: add support for " Troy Mitchell
2024-11-25 6:49 ` [PATCH v4 2/2] i2c: spacemit: add support for SpacemiT " Troy Mitchell
2025-01-04 0:34 ` Andi Shyti
2025-02-13 11:42 ` Troy Mitchell
2025-02-11 21:39 ` Alex Elder
2025-02-13 11:38 ` Troy Mitchell
2025-03-03 21:18 ` Alex Elder
2024-11-25 8:06 ` Krzysztof Kozlowski [this message]
2024-11-25 10:05 ` [PATCH v4 0/2] riscv: spacemit: add i2c support to " Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d69e1db-2ec5-445d-9336-9345c918722a@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh@kernel.org \
--cc=troymitchell988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).