[PATCH v2 0/1] Add Ethernet and PDMA support to OrangePi RV2 board

[PATCH v2 0/1] Add Ethernet and PDMA support to OrangePi RV2 board

[michael.opdenacker]

From: Michael Opdenacker <michael.opdenacker@rootcommit.com>

Reusing DTS code from the BananaPi F3 board.

iperf3 tcp performance results:

Eth1 client test (iperf3 -c <server-ip>)
[  5] local 172.24.0.2 port 41914 connected to 172.24.0.1 port 5201
[ ID] Interval           Transfer     Bitrate         Retr  Cwnd
[  5]   0.00-1.00   sec   113 MBytes   946 Mbits/sec    0    378 KBytes
[  5]   1.00-2.00   sec   112 MBytes   942 Mbits/sec    0    424 KBytes
[  5]   2.00-3.00   sec   113 MBytes   947 Mbits/sec    0    424 KBytes
[  5]   3.00-4.00   sec   112 MBytes   939 Mbits/sec    0    445 KBytes
[  5]   4.00-5.00   sec   112 MBytes   944 Mbits/sec    0    445 KBytes
[  5]   5.00-6.00   sec   112 MBytes   937 Mbits/sec    0    445 KBytes
[  5]   6.00-7.00   sec   113 MBytes   944 Mbits/sec    1    445 KBytes
[  5]   7.00-8.00   sec   112 MBytes   936 Mbits/sec    0    445 KBytes
[  5]   8.00-9.00   sec   112 MBytes   943 Mbits/sec    0    445 KBytes
[  5]   9.00-10.01  sec   114 MBytes   944 Mbits/sec    0    445 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate         Retr
[  5]   0.00-10.01  sec  1.10 GBytes   942 Mbits/sec    1            sender
[  5]   0.00-10.02  sec  1.10 GBytes   940 Mbits/sec                  receiver

Eth1 server tests (iperf3 -s)
[  5] local 172.24.0.2 port 5201 connected to 172.24.0.1 port 58420
[ ID] Interval           Transfer     Bitrate
[  5]   0.00-1.00   sec   112 MBytes   935 Mbits/sec
[  5]   1.00-2.00   sec   112 MBytes   942 Mbits/sec
[  5]   2.00-3.00   sec   112 MBytes   941 Mbits/sec
[  5]   3.00-4.00   sec   112 MBytes   941 Mbits/sec
[  5]   4.00-5.00   sec   112 MBytes   942 Mbits/sec
[  5]   5.00-6.00   sec   112 MBytes   942 Mbits/sec
[  5]   6.00-7.00   sec   112 MBytes   942 Mbits/sec
[  5]   7.00-8.00   sec   112 MBytes   942 Mbits/sec
[  5]   8.00-9.00   sec   112 MBytes   942 Mbits/sec
[  5]   9.00-10.00  sec   112 MBytes   942 Mbits/sec
[  5]  10.00-10.01  sec   512 KBytes   897 Mbits/sec
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate
[  5]   0.00-10.01  sec  1.10 GBytes   941 Mbits/sec                  receiver

Eth0 client test (iperf3 -c <server-ip>)
[  5] local 172.24.0.2 port 60496 connected to 172.24.0.1 port 5201
[ ID] Interval           Transfer     Bitrate         Retr  Cwnd
[  5]   0.00-1.00   sec   113 MBytes   947 Mbits/sec    0    362 KBytes
[  5]   1.00-2.00   sec   113 MBytes   945 Mbits/sec    0    464 KBytes
[  5]   2.00-3.00   sec   113 MBytes   945 Mbits/sec    0    464 KBytes
[  5]   3.00-4.00   sec   112 MBytes   941 Mbits/sec    0    467 KBytes
[  5]   4.00-5.00   sec   112 MBytes   940 Mbits/sec    0    467 KBytes
[  5]   5.00-6.00   sec   112 MBytes   937 Mbits/sec    0    467 KBytes
[  5]   6.00-7.00   sec   113 MBytes   948 Mbits/sec    0    494 KBytes
[  5]   7.00-8.00   sec   112 MBytes   938 Mbits/sec    0    520 KBytes
[  5]   8.00-9.00   sec   113 MBytes   945 Mbits/sec    0    520 KBytes
[  5]   9.00-10.02  sec   112 MBytes   919 Mbits/sec    0    520 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate         Retr
[  5]   0.00-10.02  sec  1.10 GBytes   941 Mbits/sec    0            sender
[  5]   0.00-10.03  sec  1.10 GBytes   940 Mbits/sec                  receiver

Eth0 server tests (iperf3 -s)
[  5] local 172.24.0.2 port 5201 connected to 172.24.0.1 port 42930
[ ID] Interval           Transfer     Bitrate
[  5]   0.00-1.00   sec   112 MBytes   934 Mbits/sec
[  5]   1.00-2.00   sec   112 MBytes   942 Mbits/sec
[  5]   2.00-3.00   sec   112 MBytes   941 Mbits/sec
[  5]   3.00-4.00   sec   112 MBytes   940 Mbits/sec
[  5]   4.00-5.00   sec   112 MBytes   942 Mbits/sec
[  5]   5.00-6.00   sec   112 MBytes   940 Mbits/sec
[  5]   6.00-7.00   sec   112 MBytes   941 Mbits/sec
[  5]   7.00-8.00   sec   112 MBytes   941 Mbits/sec
[  5]   8.00-9.00   sec   112 MBytes   942 Mbits/sec
[  5]   9.00-10.00  sec   112 MBytes   941 Mbits/sec
[  5]  10.00-10.01  sec   512 KBytes  1.07 Gbits/sec
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate
[  5]   0.00-10.01  sec  1.10 GBytes   941 Mbits/sec                  receiver

In comparison, for the 6.6 vendor kernel in OrangePiOS:
- Client tests give similar results both on eth0 and eth1
- Server tests are very similar on eth0, but lose
  between 50-60 Mbits/sec on eth1:
  [ 5] 0.00-10.00 sec 1.04 GBytes 889 Mbits/sec 56 sender
  [ 5] 0.00-10.01 sec 1.03 GBytes 882 Mbits/sec receiver
  (as seen from the PC client)

Changes in V2:
- Remove the commit configuring k1_emac driver as a built-in by default,
  as suggested by Emil Renner Berthing
- Improve the message for the commit adding Ethernet and PDMA,
  as suggested by Yixun Lan
- Add DT aliases for eth0 and eth1
  as suggested by Vivian Wang
- Add iperf3 test results to this cover letter
  as suggested by Vivian Wang

CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
CC: Yixun Lan <dlan@gentoo.org>
CC: Vivian Wang <wangruikang@iscas.ac.cn>

Michael Opdenacker (1):
  riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[michael.opdenacker]

From: Michael Opdenacker <michael.opdenacker@rootcommit.com>

The OrangePi RV2 board ships two RGMII ethernet ports.
Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
for reset pin control.

Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.

Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
CC: Yixun Lan <dlan@gentoo.org>
CC: Vivian Wang <wangruikang@iscas.ac.cn>
---
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
index 337240ebb7b7..41dc8e35e6eb 100644
--- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
@@ -15,6 +15,8 @@ / {
 
 	aliases {
 		serial0 = &uart0;
+		ethernet0 = &eth0;
+		ethernet1 = &eth1;
 	};
 
 	chosen {
@@ -33,6 +35,56 @@ led1 {
 	};
 };
 
+&eth0 {
+	phy-handle = <&rgmii0>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac0_cfg>;
+	rx-internal-delay-ps = <0>;
+	tx-internal-delay-ps = <0>;
+	status = "okay";
+
+	mdio-bus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		reset-gpios = <&gpio K1_GPIO(110) GPIO_ACTIVE_LOW>;
+		reset-delay-us = <10000>;
+		reset-post-delay-us = <100000>;
+
+		rgmii0: phy@1 {
+			reg = <0x1>;
+		};
+	};
+};
+
+&eth1 {
+	phy-handle = <&rgmii1>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac1_cfg>;
+	rx-internal-delay-ps = <0>;
+	tx-internal-delay-ps = <250>;
+	status = "okay";
+
+	mdio-bus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		reset-gpios = <&gpio K1_GPIO(115) GPIO_ACTIVE_LOW>;
+		reset-delay-us = <10000>;
+		reset-post-delay-us = <100000>;
+
+		rgmii1: phy@1 {
+			reg = <0x1>;
+		};
+	};
+};
+
+&pdma {
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Yixun Lan]

Hi Michael, 

On 20:18 Wed 22 Oct     , michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> 
> The OrangePi RV2 board ships two RGMII ethernet ports.
> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> for reset pin control.
> 
> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> CC: Yixun Lan <dlan@gentoo.org>
> CC: Vivian Wang <wangruikang@iscas.ac.cn>

Reviewed-by: Yixun Lan <dlan@gentoo.org>

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Vivian Wang]

Thank you so much for the patch and testing results. Only some nitpicks
follow.

On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> The OrangePi RV2 board ships two RGMII ethernet ports.
> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> for reset pin control.
>
> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> CC: Yixun Lan <dlan@gentoo.org>
> CC: Vivian Wang <wangruikang@iscas.ac.cn>

Firstly, it is usually spelt "Cc:", with one upper-case C and one
lower-case c.

Secondly, "Cc:" should not be necessary in the patch/commit message.
From Documentation/process/submitting-patches.rst:

    If a person has had the opportunity to comment on a patch, but has not
    provided such comments, you may optionally add a ``Cc:`` tag to the patch.
    This tag documents that potentially interested parties have been included in
    the discussion.

If you look through the git logs of Linux, Cc tags are really not a
regular occurrence except those marking patches as suitable for
backporting to stable.

Thanks,
Vivian "dramforever"


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 1724 bytes --]

On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
> Thank you so much for the patch and testing results. Only some nitpicks
> follow.
> 
> On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
> > From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> >
> > The OrangePi RV2 board ships two RGMII ethernet ports.
> > Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> > for reset pin control.
> >
> > Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
> >
> > Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> > CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> > CC: Yixun Lan <dlan@gentoo.org>
> > CC: Vivian Wang <wangruikang@iscas.ac.cn>
> 
> Firstly, it is usually spelt "Cc:", with one upper-case C and one
> lower-case c.

I don't think this matters at all, the git tooling at least doesn't
care.

> Secondly, "Cc:" should not be necessary in the patch/commit message.
> From Documentation/process/submitting-patches.rst:
> 
>     If a person has had the opportunity to comment on a patch, but has not
>     provided such comments, you may optionally add a ``Cc:`` tag to the patch.
>     This tag documents that potentially interested parties have been included in
>     the discussion.
> 
> If you look through the git logs of Linux, Cc tags are really not a
> regular occurrence except those marking patches as suitable for
> backporting to stable.

If people want to handle CC lists by putting it in the patches (it's
what I do when I have no cover letter) just put them after the --- line
and git send-email will still pick the CCs up but they won't end up in
the history.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Yixun Lan]

Hi Michael, 

Since the patch itself is good enough, so I will just take it,
I will drop those CCs if no objection..

On 19:30 Thu 23 Oct     , Conor Dooley wrote:
> On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
> > Thank you so much for the patch and testing results. Only some nitpicks
> > follow.
> > 
> > On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
> > > From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> > >
> > > The OrangePi RV2 board ships two RGMII ethernet ports.
> > > Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> > > for reset pin control.
> > >
> > > Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
> > >
> > > Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> > > CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> > > CC: Yixun Lan <dlan@gentoo.org>
> > > CC: Vivian Wang <wangruikang@iscas.ac.cn>
> > 
> > Firstly, it is usually spelt "Cc:", with one upper-case C and one
> > lower-case c.
> 
> I don't think this matters at all, the git tooling at least doesn't
> care.
> 
I think it's super useful by putting additional "Cc" into individual patch
especially for a large series to notify specific maintainers while not spam others


> > Secondly, "Cc:" should not be necessary in the patch/commit message.
> > From Documentation/process/submitting-patches.rst:
> > 
> >     If a person has had the opportunity to comment on a patch, but has not
> >     provided such comments, you may optionally add a ``Cc:`` tag to the patch.
> >     This tag documents that potentially interested parties have been included in
> >     the discussion.
> > 
> > If you look through the git logs of Linux, Cc tags are really not a
> > regular occurrence except those marking patches as suitable for
> > backporting to stable.
> 
> If people want to handle CC lists by putting it in the patches (it's
> what I do when I have no cover letter) just put them after the --- line
> and git send-email will still pick the CCs up but they won't end up in
> the history.
> 
indeed, good suggestion!


-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Michael Opdenacker]

Hi Conor

Thanks for the review!

On 10/23/25 20:30, Conor Dooley wrote:
> On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
>> Thank you so much for the patch and testing results. Only some nitpicks
>> follow.
>>
>> On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>
>>> The OrangePi RV2 board ships two RGMII ethernet ports.
>>> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
>>> for reset pin control.
>>>
>>> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
>>>
>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
>>> CC: Yixun Lan <dlan@gentoo.org>
>>> CC: Vivian Wang <wangruikang@iscas.ac.cn>
>> Firstly, it is usually spelt "Cc:", with one upper-case C and one
>> lower-case c.
> I don't think this matters at all, the git tooling at least doesn't
> care.
>
>> Secondly, "Cc:" should not be necessary in the patch/commit message.
>>  From Documentation/process/submitting-patches.rst:
>>
>>      If a person has had the opportunity to comment on a patch, but has not
>>      provided such comments, you may optionally add a ``Cc:`` tag to the patch.
>>      This tag documents that potentially interested parties have been included in
>>      the discussion.
>>
>> If you look through the git logs of Linux, Cc tags are really not a
>> regular occurrence except those marking patches as suitable for
>> backporting to stable.
> If people want to handle CC lists by putting it in the patches (it's
> what I do when I have no cover letter) just put them after the --- line
> and git send-email will still pick the CCs up but they won't end up in
> the history.

Oh yes, that was my mistake. The CCs were never intended to make it to 
the final commits.
Thanks!
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 0/1] Add Ethernet and PDMA support to OrangePi RV2 board

[Yixun Lan]

On Wed, 22 Oct 2025 20:18:30 +0000, michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> 
> Reusing DTS code from the BananaPi F3 board.
> 
> iperf3 tcp performance results:
> 
> Eth1 client test (iperf3 -c <server-ip>)
> [  5] local 172.24.0.2 port 41914 connected to 172.24.0.1 port 5201
> [ ID] Interval           Transfer     Bitrate         Retr  Cwnd
> [  5]   0.00-1.00   sec   113 MBytes   946 Mbits/sec    0    378 KBytes
> [  5]   1.00-2.00   sec   112 MBytes   942 Mbits/sec    0    424 KBytes
> [  5]   2.00-3.00   sec   113 MBytes   947 Mbits/sec    0    424 KBytes
> [  5]   3.00-4.00   sec   112 MBytes   939 Mbits/sec    0    445 KBytes
> [  5]   4.00-5.00   sec   112 MBytes   944 Mbits/sec    0    445 KBytes
> [  5]   5.00-6.00   sec   112 MBytes   937 Mbits/sec    0    445 KBytes
> [  5]   6.00-7.00   sec   113 MBytes   944 Mbits/sec    1    445 KBytes
> [  5]   7.00-8.00   sec   112 MBytes   936 Mbits/sec    0    445 KBytes
> [  5]   8.00-9.00   sec   112 MBytes   943 Mbits/sec    0    445 KBytes
> [  5]   9.00-10.01  sec   114 MBytes   944 Mbits/sec    0    445 KBytes
> - - - - - - - - - - - - - - - - - - - - - - - - -
> [ ID] Interval           Transfer     Bitrate         Retr
> [  5]   0.00-10.01  sec  1.10 GBytes   942 Mbits/sec    1            sender
> [  5]   0.00-10.02  sec  1.10 GBytes   940 Mbits/sec                  receiver
> 
> [...]

Applied, thanks!

[1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2
      https://github.com/spacemit-com/linux/commit/9813395078352fed03c88742bd39b9c4a0e40c15

Best regards,
-- 
Yixun Lan


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Johannes Erdfelt]

On Wed, Oct 22, 2025, michael.opdenacker@rootcommit.com <michael.opdenacker@rootcommit.com> wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> 
> The OrangePi RV2 board ships two RGMII ethernet ports.
> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> for reset pin control.
> 
> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> CC: Yixun Lan <dlan@gentoo.org>
> CC: Vivian Wang <wangruikang@iscas.ac.cn>

I tested this patch on my RV2 board. I see similar iperf3 results.

Tested-by: Johannes Erdfelt <johannes@erdfelt.com>

JE


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv