From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA2C2C7618A for ; Sun, 19 Mar 2023 13:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NASJHqLycl09mAw4V/6N0TwvfwRTPMRVkFlKxh3PjCA=; b=ei2IaT2RE2dlyk P04nb2G7IW5Mo+HF8Kb7NKX5DX8RUlSR0BxCQ4NPOVkYVzfqVtwIKEwtNj+XSrT2c4BOnpsXsjsmw ccK8gUOqQJAun2SogKGOL+U0lzKiZFGEDfHbOTl3vLLxMibujIPrrcHNXSReXj3erY3VRGLnYbGyo /BHWgShRKbM/Wstr4Oo88lvnV8q3EZvJbqWkytH1NY/J7ulz7mFiNJQxVQMwvAXbX54l/sP8YQnAJ C4TBmIKksyaGC8CVp3aLiH7A2HFU7IAZkq2JUjfNhELv3f1L3HLZbFZRTHq8sSPCZsG1Rwfpqeca9 RlxmvP+ZrwjtMwzobOuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdt5l-006oPP-2n; Sun, 19 Mar 2023 13:28:57 +0000 Received: from fd01.gateway.ufhost.com ([61.152.239.71]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdt5f-006oNx-1l for linux-riscv@lists.infradead.org; Sun, 19 Mar 2023 13:28:56 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 43CB624DC09; Sun, 19 Mar 2023 21:28:07 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sun, 19 Mar 2023 21:28:07 +0800 Received: from [172.16.16.231] (183.27.96.84) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sun, 19 Mar 2023 21:28:06 +0800 Message-ID: <6294ffee-3c66-5287-59b4-068a7f4e84ba@starfivetech.com> Date: Sun, 19 Mar 2023 21:28:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 12/21] dt-bindings: clock: Add StarFive JH7110 always-on clock and reset generator To: Conor Dooley CC: , , , Stephen Boyd , "Michael Turquette" , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Palmer Dabbelt , Paul Walmsley , Albert Ou , Ben Dooks , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , "Emil Renner Berthing" , References: <20230311090733.56918-1-hal.feng@starfivetech.com> <20230311090733.56918-13-hal.feng@starfivetech.com> Content-Language: en-US From: Hal Feng In-Reply-To: X-Originating-IP: [183.27.96.84] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230319_062852_098592_FDD6B7CD X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, 11 Mar 2023 13:14:45 +0000, Conor Dooley wrote: > On Sat, Mar 11, 2023 at 05:07:24PM +0800, Hal Feng wrote: >> From: Emil Renner Berthing >> >> Add bindings for the always-on clock and reset generator (AONCRG) on the >> JH7110 RISC-V SoC by StarFive Ltd. >> >> Signed-off-by: Emil Renner Berthing >> Signed-off-by: Hal Feng >> +++ b/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml >> @@ -0,0 +1,107 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/starfive,jh7110-aoncrg.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 Always-On Clock and Reset Generator >> + >> +maintainers: >> + - Emil Renner Berthing >> + >> +properties: >> + compatible: >> + const: starfive,jh7110-aoncrg >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + oneOf: >> + - items: >> + - description: Main Oscillator (24 MHz) >> + - description: GMAC0 RMII reference or GMAC0 RGMII RX >> + - description: STG AXI/AHB >> + - description: APB Bus >> + - description: GMAC0 GTX >> + >> + - items: >> + - description: Main Oscillator (24 MHz) >> + - description: GMAC0 RMII reference or GMAC0 RGMII RX >> + - description: STG AXI/AHB or GMAC0 RGMII RX >> + - description: APB Bus or STG AXI/AHB >> + - description: GMAC0 GTX or APB Bus >> + - description: RTC Oscillator (32.768 kHz) or GMAC0 GTX > > Something tells me that the use of "or" means we're not doing this > correctly. > Otherwise, > Reviewed-by: Conor Dooley There are two possible cases when the number of clock inputs is 6: Main Oscillator GMAC0 RMII reference or GMAC0 RGMII RX STG AXI/AHB APB Bus GMAC0 GTX RTC Oscillator and Main Oscillator GMAC0 RMII reference GMAC0 RGMII RX STG AXI/AHB APB Bus GMAC0 GTX So I used the "or" in the items descriptions. Thanks. Best regards, Hal > >> + - items: >> + - description: Main Oscillator (24 MHz) >> + - description: GMAC0 RMII reference >> + - description: GMAC0 RGMII RX >> + - description: STG AXI/AHB >> + - description: APB Bus >> + - description: GMAC0 GTX >> + - description: RTC Oscillator (32.768 kHz) >> + >> + clock-names: >> + oneOf: >> + - minItems: 5 >> + items: >> + - const: osc >> + - enum: >> + - gmac0_rmii_refin >> + - gmac0_rgmii_rxin >> + - const: stg_axiahb >> + - const: apb_bus >> + - const: gmac0_gtxclk >> + - const: rtc_osc >> + >> + - minItems: 6 >> + items: >> + - const: osc >> + - const: gmac0_rmii_refin >> + - const: gmac0_rgmii_rxin >> + - const: stg_axiahb >> + - const: apb_bus >> + - const: gmac0_gtxclk >> + - const: rtc_osc > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv