From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yao Zi <ziyao@disroot.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Inochi Amaoto <inochiama@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Jisheng Zhang <jszhang@kernel.org>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: phy: add YAML schema for cv1800-usb-phy driver bindings
Date: Mon, 8 Jul 2024 15:40:52 +0200 [thread overview]
Message-ID: <64d32e69-a216-4f63-9da5-0686b8706dd3@kernel.org> (raw)
In-Reply-To: <20240708120830.5785-2-ziyao@disroot.org>
On 08/07/2024 14:08, Yao Zi wrote:
> cv1800-usb-phy driver supports USB 2.0 phys integrated in Sophgo
> Cv1800/SG200x SoCs. Add YAML schema for its binding.
>
> Signed-off-by: Yao Zi <ziyao@disroot.org>
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> +properties:
> + compatible:
> + enum:
> + - sophgo,cv1800-usb-phy
> +
> + reg:
> + maxItems: 2
> +
> + reg-names:
> + items:
> + - const: phy
> + - const: pin
> +
> + clocks:
> + maxItems: 4
> +
> + clock-names:
> + items:
> + - const: apb
> + - const: 125m
> + - const: 33k
> + - const: 12m
All these three should have rather some logical name, not frequency.
> +
> + "#phy-cells":
> + const: 0
> +
> + dr_role:
No underscores in node names, missing vendor prefix (unless it is
generic property), missing description.
Please do not invent new properties like this. You probably wanted to
reference usb-drd?
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-07-08 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 12:08 [PATCH 0/3] Add USB support for Sophgo CV1800/SG200x SoCs Yao Zi
2024-07-08 12:08 ` [PATCH 1/3] dt-bindings: phy: add YAML schema for cv1800-usb-phy driver bindings Yao Zi
2024-07-08 13:40 ` Krzysztof Kozlowski [this message]
2024-07-08 22:23 ` Inochi Amaoto
2024-07-08 23:54 ` Chen Wang
2024-07-09 7:07 ` Yao Zi
2024-07-08 12:08 ` [PATCH 2/3] riscv: dts: sophgo: add nodes for USB phy and controller Yao Zi
2024-07-08 13:41 ` Krzysztof Kozlowski
2024-07-08 12:08 ` [PATCH 3/3] phy: sophgo: add usb phy driver for Sophgo CV1800 SoCs Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64d32e69-a216-4f63-9da5-0686b8706dd3@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=unicorn_wang@outlook.com \
--cc=vkoul@kernel.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox