public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Conor Dooley <conor@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	linux-riscv@lists.infradead.org, ajones@ventanamicro.com,
	aou@eecs.berkeley.edu, corbet@lwn.net, guoren@kernel.org,
	heiko@sntech.de, paul.walmsley@sifive.com,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v1 3/3] Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo
Date: Fri, 2 Dec 2022 09:14:08 +0700	[thread overview]
Message-ID: <66b3fd78-31bc-c435-ccc8-c8682b3cacee@gmail.com> (raw)
In-Reply-To: <Y4hjIWHTuYcf90ja@wendy>

On 12/1/22 15:17, Conor Dooley wrote:
> On Thu, Dec 01, 2022 at 10:05:32AM +0700, Bagas Sanjaya wrote:
>> On Wed, Nov 30, 2022 at 11:41:26PM +0000, Conor Dooley wrote:
>>> +#. Single-letter extensions come first, in "canonical order", so
>>> +   "IMAFDQLCBKJTPVH".
>>
>> "..., that is ... ."
> 
> Hmm, that reads strangely to me. s/that/which/.
> 

OK.

>>
>>> +#. The first letter following the 'Z' conventionally indicates the most
>>> +   closely related alphabetical extension category, IMAFDQLCBKJTPVH.
>>> +   If multiple 'Z' extensions are named, they should be ordered first by
>>> +   category, then alphabetically within a category.
>>> +
>>
>> Did you mean "most closely related alphabetical extension category in
>> canonical order"?
> 
> I am not 100% sure what you are suggesting a replacement of here. I
> think I may reword this as:
>   For additional standard extensions, the first letter following the 'Z'
>   conventionally indicates the most closely related alphabetical
>   extension category. If multiple 'Z' extensions are named, they will
>   be ordered first by category, in canonical order as listed above, then
>   alphabetically within a category.
> 

That LGTM.

>>> +An example string following the order is:
>>> +   rv64imadc_zifoo_zigoo_zafoo_sbar_scar_zxmbaz_xqux_xrux
>>> +
>>  
>> IMO literal code block should be better fit for the example above,
>> rather than definition list:
> 
> Uh, sure? I'm not sure what impact that has on the output, but I can
> switch to a pre-formatted block.
> 

Something like ``foo``?

Thanks.

-- 
An old man doll... just what I always wanted! - Clara


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-12-02  2:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 23:41 [PATCH v1 0/3] Putting some basic order on isa extension lists Conor Dooley
2022-11-30 23:41 ` [PATCH v1 1/3] RISC-V: clarify ISA string ordering rules in cpu.c Conor Dooley
2022-12-01  8:27   ` Andrew Jones
2022-12-01  8:48     ` Conor Dooley
2022-11-30 23:41 ` [PATCH v1 2/3] RISC-V: resort all extensions in consistent orders Conor Dooley
2022-12-01  9:00   ` Andrew Jones
2022-12-01 10:47     ` Heiko Stübner
2022-12-01 11:38       ` Andrew Jones
2022-12-01 12:29     ` Conor Dooley
2022-12-01 12:37       ` Conor.Dooley
2022-12-01 10:48   ` Heiko Stübner
2022-11-30 23:41 ` [PATCH v1 3/3] Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo Conor Dooley
2022-11-30 23:46   ` Conor Dooley
2022-12-01  3:05   ` Bagas Sanjaya
2022-12-01  8:17     ` Conor Dooley
2022-12-02  2:14       ` Bagas Sanjaya [this message]
2022-12-02 11:37         ` Conor Dooley
2022-12-01  9:14   ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66b3fd78-31bc-c435-ccc8-c8682b3cacee@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=ajones@ventanamicro.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=corbet@lwn.net \
    --cc=guoren@kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox