From: Shuah Khan <skhan@linuxfoundation.org>
To: "Björn Töpel" <bjorn@kernel.org>, "Tejun Heo" <tj@kernel.org>,
"David Vernet" <void@manifault.com>,
"Shuah Khan" <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Mark Brown" <broonie@kernel.org>
Cc: "Björn Töpel" <bjorn@rivosinc.com>,
bpf@vger.kernel.org, linux-riscv@lists.infradead.org,
"Anders Roxell" <anders.roxell@linaro.org>
Subject: Re: [PATCH] selftests: sched_ext: Add sched_ext as proper selftest target
Date: Fri, 4 Oct 2024 12:41:50 -0600 [thread overview]
Message-ID: <67224962-4ea4-4d78-923f-2c520488a090@linuxfoundation.org> (raw)
In-Reply-To: <60dd0240-8e45-4958-acf2-7eeee917785b@linuxfoundation.org>
On 10/4/24 11:46, Shuah Khan wrote:
> On 10/4/24 03:42, Björn Töpel wrote:
>> From: Björn Töpel <bjorn@rivosinc.com>
>>
>> The sched_ext selftests is missing proper cross-compilation support, a
>> proper target entry, and out-of-tree build support.
>>
>> When building the kselftest suite, e.g.:
>>
>> make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- \
>> SKIP_TARGETS="" O=/output/foo -C tools/testing/selftests install
>>
>> The expectation is that the sched_ext is included, cross-built, and
>> placed into /output/foo.
>>
>> Add CROSS_COMPILE, OUTPUT, and TARGETS support to the sched_ext
>> selftest.
>>
>> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
>> ---
>> tools/testing/selftests/Makefile | 1 +
>> tools/testing/selftests/sched_ext/Makefile | 59 +++++++++++++++-------
>> 2 files changed, 41 insertions(+), 19 deletions(-)
>>
>
> Thank you for the find. It appears *sched* is also missing
> from the default TARGETS in selftests/Makefile
>
> This change looks good to me.
>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
>
> Tejun, Do let me know if you like me to take this through kselftest tree.
>
Please don't take this patch at the moment.
Adding Mark.
After catching up with my Inbox - this is a no for me. This test
depends on bpf and will fail in CIs that don't have the support.
We are discussing the issue here in this thread.
https://patchwork.kernel.org/project/linux-kselftest/patch/20241004095348.797020-1-bjorn@kernel.org/
thanks,
-- Shuah
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-10-04 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 9:42 [PATCH] selftests: sched_ext: Add sched_ext as proper selftest target Björn Töpel
2024-10-04 17:46 ` Shuah Khan
2024-10-04 18:41 ` Shuah Khan [this message]
2024-10-04 19:00 ` David Vernet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67224962-4ea4-4d78-923f-2c520488a090@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=anders.roxell@linaro.org \
--cc=bjorn@kernel.org \
--cc=bjorn@rivosinc.com \
--cc=bpf@vger.kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox