Re: [PATCH v2 06/36] pinctrl: at91: Add missed header(s)

From: <Claudiu.Beznea@microchip.com>
To: <andriy.shevchenko@linux.intel.com>, <maz@kernel.org>,
	<brgl@bgdev.pl>, <warthog618@gmail.com>, <mchehab@kernel.org>,
	<billy_tsai@aspeedtech.com>, <tglx@linutronix.de>,
	<linus.walleij@linaro.org>, <mika.westerberg@linux.intel.com>,
	<angelogioacchino.delregno@collabora.com>, <wenst@chromium.org>,
	<samuel@sholland.org>, <Horatiu.Vultur@microchip.com>,
	<rafal@milecki.pl>, <bjorn.andersson@linaro.org>,
	<dmitry.baryshkov@linaro.org>, <geert+renesas@glider.be>,
	<prabhakar.mahadev-lad.rj@bp.renesas.com>,
	<phil.edworthy@renesas.com>, <krzysztof.kozlowski@linaro.org>,
	<fabien.dessenne@foss.st.com>, <pshete@nvidia.com>,
	<Basavaraj.Natikar@amd.com>, <linux-gpio@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-media@vger.kernel.org>,
	<linux-actions@lists.infradead.org>,
	<linux-aspeed@lists.ozlabs.org>, <openbmc@lists.ozlabs.org>,
	<linux-rpi-kernel@lists.infradead.org>,
	<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
	<linux-mediatek@lists.infradead.org>,
	<linux-mips@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
	<linux-omap@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-msm@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>,
	<linux-samsung-soc@vger.kernel.org>
Cc: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<patrice.chotard@foss.st.com>, <afaerber@suse.de>,
	<mani@kernel.org>, <andrew@aj.id.au>, <joel@jms.id.au>,
	<f.fainelli@gmail.com>, <rjui@broadcom.com>,
	<sbranden@broadcom.com>, <bcm-kernel-feedback-list@broadcom.com>,
	<ckeepax@opensource.cirrus.com>, <rf@opensource.cirrus.com>,
	<aisheng.dong@nxp.com>, <festevam@gmail.com>,
	<shawnguo@kernel.org>, <ping.bai@nxp.com>,
	<kernel@pengutronix.de>, <s.hauer@pengutronix.de>,
	<linux-imx@nxp.com>, <andy@kernel.org>, <sean.wang@kernel.org>,
	<andrew@lunn.ch>, <gregory.clement@bootlin.com>,
	<sebastian.hesselbarth@gmail.com>, <avifishman70@gmail.com>,
	<tmaimon77@gmail.com>, <tali.perry1@gmail.com>,
	<venture@google.com>, <yuenn@google.com>,
	<benjaminfair@google.com>, <Ludovic.Desroches@microchip.com>,
	<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
	<wens@csie.org>, <paul@crapouillou.net>, <damien.lemoal@wdc.com>,
	<tony@atomide.com>, <haojian.zhuang@linaro.org>,
	<mcoquelin.stm32@gmail.com>, <alexandre.torgue@foss.st.com>,
	<michal.simek@xilinx.com>, <agross@kernel.org>,
	<konrad.dybcio@somainline.org>, <tomasz.figa@gmail.com>,
	<s.nawrocki@samsung.com>, <alim.akhtar@samsung.com>,
	<vireshk@kernel.org>, <shiraz.linux.kernel@gmail.com>,
	<soc@kernel.org>, <orsonzhai@gmail.com>,
	<baolin.wang@linux.alibaba.com>, <zhang.lyra@gmail.com>,
	<kernel@esmil.dk>, <hayashi.kunihiko@socionext.com>,
	<mhiramat@kernel.org>
Subject: Re: [PATCH v2 06/36] pinctrl: at91: Add missed header(s)
Date: Wed, 12 Oct 2022 07:52:49 +0000	[thread overview]
Message-ID: <6846a969-028c-f499-2e15-4ae2536edaa9@microchip.com> (raw)
In-Reply-To: <20221010201453.77401-7-andriy.shevchenko@linux.intel.com>

On 10.10.2022 23:14, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Do not imply that some of the generic headers may be always included.
> Instead, include explicitly what we are direct user of.
> 
> While at it, sort headers alphabetically.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> ---
>  drivers/pinctrl/pinctrl-at91-pio4.c | 10 +++++++---
>  drivers/pinctrl/pinctrl-at91.c      | 16 +++++++++-------
>  2 files changed, 16 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index 82b921fd630d..e38c683aba09 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -7,18 +7,22 @@
>   */
> 
>  #include <dt-bindings/pinctrl/at91.h>
> +
>  #include <linux/clk.h>
>  #include <linux/gpio/driver.h>
> +#include <linux/init.h>
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
> -#include <linux/init.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
> -#include <linux/pinctrl/pinconf.h>
> +#include <linux/seq_file.h>
> +#include <linux/slab.h>
> +
>  #include <linux/pinctrl/pinconf-generic.h>
> +#include <linux/pinctrl/pinconf.h>
>  #include <linux/pinctrl/pinctrl.h>
>  #include <linux/pinctrl/pinmux.h>
> -#include <linux/slab.h>
> +
>  #include "core.h"
>  #include "pinconf.h"
>  #include "pinctrl-utils.h"
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 81dbffab621f..1e1813d7c550 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -7,22 +7,24 @@
> 
>  #include <linux/clk.h>
>  #include <linux/err.h>
> +#include <linux/gpio/driver.h>
>  #include <linux/init.h>
> +#include <linux/interrupt.h>
> +#include <linux/io.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/of_address.h>
> +#include <linux/of_device.h>
>  #include <linux/of_irq.h>
> +#include <linux/pm.h>
> +#include <linux/seq_file.h>
>  #include <linux/slab.h>
> -#include <linux/interrupt.h>
> -#include <linux/io.h>
> -#include <linux/gpio/driver.h>
> +
> +/* Since we request GPIOs from ourself */
> +#include <linux/pinctrl/consumer.h>
>  #include <linux/pinctrl/machine.h>
>  #include <linux/pinctrl/pinconf.h>
>  #include <linux/pinctrl/pinctrl.h>
>  #include <linux/pinctrl/pinmux.h>
> -/* Since we request GPIOs from ourself */
> -#include <linux/pinctrl/consumer.h>
> -#include <linux/pm.h>
> 
>  #include "pinctrl-at91.h"
>  #include "core.h"
> --
> 2.35.1
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv