Re: [PATCH v1 1/2] LRW UART: dt-bindings: Add binding for LRW UART

From: Krzysztof Kozlowski <krzk@kernel.org>
To: LiuQingtao <qtliu@mail.ustc.edu.cn>, gregkh@linuxfoundation.org
Cc: jirislaby@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, neil.armstrong@linaro.org,
	bjorn.andersson@oss.qualcomm.com, marex@nabladev.com,
	dev@kael-k.io, mani@kernel.org,
	prabhakar.mahadev-lad.rj@bp.renesas.com,
	linux-serial@vger.kernel.org, linux-riscv@lists.infradead.org,
	liu.wenhong35@zte.com.cn, liu.qingtao2@zte.com.cn,
	hu.yuye@zte.com.cn, dai.hualiang@zte.com.cn,
	deng.weixian@zte.com.cn, jia.yunxiang@zte.com.cn,
	bai.lu5@zte.com.cn, yang.susheng@zte.com.cn,
	shen.lin1@zte.com.cn, tan.hu@zte.com.cn, zuo.jiang@zte.com.cn
Subject: Re: [PATCH v1 1/2] LRW UART: dt-bindings: Add binding for LRW UART
Date: Fri, 13 Feb 2026 11:00:10 +0100	[thread overview]
Message-ID: <6ba2a916-739c-4c4a-92a6-951707aaa212@kernel.org> (raw)
In-Reply-To: <20260213093334.9217-2-qtliu@mail.ustc.edu.cn>

On 13/02/2026 10:33, LiuQingtao wrote:
> From: Wenhong Liu <liu.wenhong35@zte.com.cn>
> 
> Add documentation for LRW UART devicetree bindings.
> 
> Signed-off-by: Wenhong Liu <liu.wenhong35@zte.com.cn>
> Signed-off-by: Qingtao Liu <liu.qingtao2@zte.com.cn>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> ---
>  .../bindings/serial/lrw,lrw-uart.yaml         | 49 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  MAINTAINERS                                   |  7 +++
>  3 files changed, 58 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
> 
> diff --git a/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml b/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
> new file mode 100644
> index 000000000000..a2d41c278c4f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/lrw-uart.yaml#

Never tested, NAK. There are several other issues here, but I am not
going through rest of review if you did not bother to even build test
it. Please open any other recent binding and apply same style here
(filename, descriptions etc), so you won't be repeating SAME mistakes.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LRW serial UART
> +
> +maintainers:
> +  - Wenhong Liu <liu.wenhong35@zte.com.cn>
> +  - Qingtao Liu <liu.qingtao2@zte.com.cn>
> +
> +description: |
> +  Should be something similar to "lrw,<chip>-uart"
> +  for the UART as integrated on a particular chip, It supports
> +  multiple CPU architectures, currently including e.g. RISC-V and ARM.
> +
> +properties:
> +  compatible:
> +    const: lrw,lrw-uart

No way lrw is a chip if this is a company.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - current-speed
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    uart0: serial@e0001800 {
> +      compatible = "lrw,lrw-uart";
> +      interrupt-parent = <&aplic0>;
> +      interrupts = <0x12 0x4>;
> +      reg = <0xe0001800 0x100>;
> +      clocks = <&bar_clk>;
> +      current-speed = <115200>;
> +    };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index ee7fd3cfe203..ec9bf262f466 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -961,6 +961,8 @@ patternProperties:
>      description: Loongson Technology Corporation Limited
>    "^loongmasses,.*":
>      description: Nanjing Loongmasses Ltd.
> +  "^lrw,.*":
> +    description: LRW Corp.

What is the website/domain address?

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv