From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chen Wang <unicornxw@gmail.com>,
aou@eecs.berkeley.edu, chao.wei@sophgo.com, conor@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
palmer@dabbelt.com, paul.walmsley@sifive.com,
richardcochran@gmail.com, robh+dt@kernel.org, sboyd@kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com,
guoren@kernel.org, jszhang@kernel.org, inochiama@outlook.com,
samuel.holland@sifive.com
Cc: Chen Wang <unicorn_wang@outlook.com>
Subject: Re: [PATCH v8 1/5] dt-bindings: clock: sophgo: add sysclk for SG2042
Date: Tue, 16 Jan 2024 11:09:00 +0100 [thread overview]
Message-ID: <6badfa7b-543f-4aa0-87db-bac27c2d1f46@linaro.org> (raw)
In-Reply-To: <7071845b8d1ff6aa91112c91feb62bc875066d9e.1705388518.git.unicorn_wang@outlook.com>
On 16/01/2024 08:20, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@outlook.com>
>
> Add bindings for the clocks of which configuration registers are in the
> range of SYS_CTRL in the memory-map.
This means it is not a separate device and should be just merged with
parent node. Otherwise please give us some arguments why this should be
a separate device node.
>
> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
>
> .
Some stray characters above ^^^. Clean your commit msg. Also, I have
doubts it passes checkpatch.
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-01-16 10:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 7:20 [PATCH v8 0/5] riscv: sophgo: add clock support for sg2042 Chen Wang
2024-01-16 7:20 ` [PATCH v8 1/5] dt-bindings: clock: sophgo: add sysclk for SG2042 Chen Wang
2024-01-16 10:09 ` Krzysztof Kozlowski [this message]
2024-01-16 7:21 ` [PATCH v8 2/5] dt-bindings: soc: sophgo: Add Sophgo system control module Chen Wang
2024-01-16 10:06 ` Krzysztof Kozlowski
2024-01-16 11:37 ` Chen Wang
2024-01-16 12:15 ` Krzysztof Kozlowski
2024-01-18 5:29 ` Chen Wang
2024-01-22 3:41 ` Chen Wang
2024-01-22 8:10 ` Krzysztof Kozlowski
2024-01-22 10:11 ` Chen Wang
2024-01-22 12:56 ` Krzysztof Kozlowski
2024-01-23 9:28 ` Chen Wang
2024-01-16 7:21 ` [PATCH v8 3/5] dt-bindings: clock: sophgo: add clkgen for SG2042 Chen Wang
2024-01-16 7:22 ` [PATCH v8 4/5] clk: sophgo: Add SG2042 clock generator driver Chen Wang
2024-01-16 7:22 ` [PATCH v8 5/5] riscv: dts: add clock generator for Sophgo SG2042 SoC Chen Wang
2024-01-16 9:47 ` [PATCH v8 0/5] riscv: sophgo: add clock support for sg2042 Krzysztof Kozlowski
2024-01-16 11:39 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6badfa7b-543f-4aa0-87db-bac27c2d1f46@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=haijiao.liu@sophgo.com \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=sboyd@kernel.org \
--cc=unicorn_wang@outlook.com \
--cc=unicornxw@gmail.com \
--cc=xiaoguang.xing@sophgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).