* [PATCH 0/2] RISC-V: KVM: Require alternatives
@ 2023-03-22 19:28 Andrew Jones
2023-03-22 19:28 ` [PATCH 1/2] RISC-V: KVM: Alphabetize selects Andrew Jones
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Andrew Jones @ 2023-03-22 19:28 UTC (permalink / raw)
To: linux-riscv, kvm-riscv
Cc: 'Palmer Dabbelt ', 'Anup Patel ',
'Paul Walmsley ', 'Atish Patra ',
'Albert Ou '
KVM makes use of riscv_has_extension_unlikely() to check for the
svinval extension. riscv_has_extension_unlikely() is built on
alternatives, which means KVM should ensure alternatives support
is available.
The first patch takes the opportunity to cleanup KVM's select
list. The second patch selects RISCV_ALTERNATIVE.
Thanks,
drew
Andrew Jones (2):
RISC-V: KVM: Alphabetize selects
RISC-V: KVM: Require alternatives
arch/riscv/kvm/Kconfig | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
--
2.39.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/2] RISC-V: KVM: Alphabetize selects 2023-03-22 19:28 [PATCH 0/2] RISC-V: KVM: Require alternatives Andrew Jones @ 2023-03-22 19:28 ` Andrew Jones 2023-04-07 11:47 ` Anup Patel 2023-03-22 19:28 ` [PATCH 2/2] RISC-V: KVM: Require alternatives Andrew Jones 2023-03-22 19:40 ` [PATCH 0/2] " Conor Dooley 2 siblings, 1 reply; 11+ messages in thread From: Andrew Jones @ 2023-03-22 19:28 UTC (permalink / raw) To: linux-riscv, kvm-riscv Cc: 'Palmer Dabbelt ', 'Anup Patel ', 'Paul Walmsley ', 'Atish Patra ', 'Albert Ou ' While alphabetized lists tend to become unalphabetized almost as quickly as they get fixed up, it is preferred to keep select lists in Kconfigs in order. Let's fix KVM's up. Signed-off-by: Andrew Jones <ajones@ventanamicro.com> --- arch/riscv/kvm/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig index d5a658a047a7..5bcb2d519b95 100644 --- a/arch/riscv/kvm/Kconfig +++ b/arch/riscv/kvm/Kconfig @@ -20,14 +20,14 @@ if VIRTUALIZATION config KVM tristate "Kernel-based Virtual Machine (KVM) support (EXPERIMENTAL)" depends on RISCV_SBI && MMU + select HAVE_KVM_EVENTFD + select HAVE_KVM_VCPU_ASYNC_IOCTL + select KVM_GENERIC_DIRTYLOG_READ_PROTECT select KVM_GENERIC_HARDWARE_ENABLING - select MMU_NOTIFIER - select PREEMPT_NOTIFIERS select KVM_MMIO - select KVM_GENERIC_DIRTYLOG_READ_PROTECT select KVM_XFER_TO_GUEST_WORK - select HAVE_KVM_VCPU_ASYNC_IOCTL - select HAVE_KVM_EVENTFD + select MMU_NOTIFIER + select PREEMPT_NOTIFIERS select SRCU help Support hosting virtualized guest machines. -- 2.39.2 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] RISC-V: KVM: Alphabetize selects 2023-03-22 19:28 ` [PATCH 1/2] RISC-V: KVM: Alphabetize selects Andrew Jones @ 2023-04-07 11:47 ` Anup Patel 0 siblings, 0 replies; 11+ messages in thread From: Anup Patel @ 2023-04-07 11:47 UTC (permalink / raw) To: Andrew Jones Cc: linux-riscv, kvm-riscv, Palmer Dabbelt, Paul Walmsley, Atish Patra, Albert Ou On Thu, Mar 23, 2023 at 12:59 AM Andrew Jones <ajones@ventanamicro.com> wrote: > > While alphabetized lists tend to become unalphabetized almost > as quickly as they get fixed up, it is preferred to keep select > lists in Kconfigs in order. Let's fix KVM's up. > > Signed-off-by: Andrew Jones <ajones@ventanamicro.com> Reviewed-by: Anup Patel <anup@brainfault.org> Queued this patch for Linux-6.4 Thanks, Anup > --- > arch/riscv/kvm/Kconfig | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig > index d5a658a047a7..5bcb2d519b95 100644 > --- a/arch/riscv/kvm/Kconfig > +++ b/arch/riscv/kvm/Kconfig > @@ -20,14 +20,14 @@ if VIRTUALIZATION > config KVM > tristate "Kernel-based Virtual Machine (KVM) support (EXPERIMENTAL)" > depends on RISCV_SBI && MMU > + select HAVE_KVM_EVENTFD > + select HAVE_KVM_VCPU_ASYNC_IOCTL > + select KVM_GENERIC_DIRTYLOG_READ_PROTECT > select KVM_GENERIC_HARDWARE_ENABLING > - select MMU_NOTIFIER > - select PREEMPT_NOTIFIERS > select KVM_MMIO > - select KVM_GENERIC_DIRTYLOG_READ_PROTECT > select KVM_XFER_TO_GUEST_WORK > - select HAVE_KVM_VCPU_ASYNC_IOCTL > - select HAVE_KVM_EVENTFD > + select MMU_NOTIFIER > + select PREEMPT_NOTIFIERS > select SRCU > help > Support hosting virtualized guest machines. > -- > 2.39.2 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/2] RISC-V: KVM: Require alternatives 2023-03-22 19:28 [PATCH 0/2] RISC-V: KVM: Require alternatives Andrew Jones 2023-03-22 19:28 ` [PATCH 1/2] RISC-V: KVM: Alphabetize selects Andrew Jones @ 2023-03-22 19:28 ` Andrew Jones 2023-03-22 19:40 ` [PATCH 0/2] " Conor Dooley 2 siblings, 0 replies; 11+ messages in thread From: Andrew Jones @ 2023-03-22 19:28 UTC (permalink / raw) To: linux-riscv, kvm-riscv Cc: 'Palmer Dabbelt ', 'Anup Patel ', 'Paul Walmsley ', 'Atish Patra ', 'Albert Ou ' KVM makes use of riscv_has_extension_unlikely() to check for the svinval extension. riscv_has_extension_unlikely() is built on alternatives, which means KVM should ensure alternatives support is available. Select RISCV_ALTERNATIVE from KVM. Fixes: e8ad17d2b5f3 ("riscv: KVM: Switch has_svinval() to riscv_has_extension_unlikely()") Signed-off-by: Andrew Jones <ajones@ventanamicro.com> --- arch/riscv/kvm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig index 5bcb2d519b95..9dd61db0acc5 100644 --- a/arch/riscv/kvm/Kconfig +++ b/arch/riscv/kvm/Kconfig @@ -28,6 +28,7 @@ config KVM select KVM_XFER_TO_GUEST_WORK select MMU_NOTIFIER select PREEMPT_NOTIFIERS + select RISCV_ALTERNATIVE select SRCU help Support hosting virtualized guest machines. -- 2.39.2 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] RISC-V: KVM: Require alternatives 2023-03-22 19:28 [PATCH 0/2] RISC-V: KVM: Require alternatives Andrew Jones 2023-03-22 19:28 ` [PATCH 1/2] RISC-V: KVM: Alphabetize selects Andrew Jones 2023-03-22 19:28 ` [PATCH 2/2] RISC-V: KVM: Require alternatives Andrew Jones @ 2023-03-22 19:40 ` Conor Dooley 2023-03-23 17:57 ` Conor Dooley 2 siblings, 1 reply; 11+ messages in thread From: Conor Dooley @ 2023-03-22 19:40 UTC (permalink / raw) To: Andrew Jones Cc: linux-riscv, kvm-riscv, 'Palmer Dabbelt ', 'Anup Patel ', 'Paul Walmsley ', 'Atish Patra ', 'Albert Ou ' [-- Attachment #1.1: Type: text/plain, Size: 585 bytes --] On Wed, Mar 22, 2023 at 08:28:56PM +0100, Andrew Jones wrote: > KVM makes use of riscv_has_extension_unlikely() to check for the > svinval extension. riscv_has_extension_unlikely() is built on > alternatives, which means KVM should ensure alternatives support > is available. > > The first patch takes the opportunity to cleanup KVM's select > list. The second patch selects RISCV_ALTERNATIVE. Reminds me, I need to re-submit my patch doing that for the top-level RISC-V Kconfig... For the pair: Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] RISC-V: KVM: Require alternatives 2023-03-22 19:40 ` [PATCH 0/2] " Conor Dooley @ 2023-03-23 17:57 ` Conor Dooley 2023-03-23 19:05 ` Andrew Jones 2023-03-24 11:32 ` Andrew Jones 0 siblings, 2 replies; 11+ messages in thread From: Conor Dooley @ 2023-03-23 17:57 UTC (permalink / raw) To: Andrew Jones Cc: linux-riscv, kvm-riscv, 'Palmer Dabbelt ', 'Anup Patel ', 'Paul Walmsley ', 'Atish Patra ', 'Albert Ou ' [-- Attachment #1.1: Type: text/plain, Size: 1122 bytes --] On Wed, Mar 22, 2023 at 07:40:14PM +0000, Conor Dooley wrote: > On Wed, Mar 22, 2023 at 08:28:56PM +0100, Andrew Jones wrote: > > KVM makes use of riscv_has_extension_unlikely() to check for the > > svinval extension. riscv_has_extension_unlikely() is built on > > alternatives, which means KVM should ensure alternatives support > > is available. > > > > The first patch takes the opportunity to cleanup KVM's select > > list. The second patch selects RISCV_ALTERNATIVE. > > Reminds me, I need to re-submit my patch doing that for the top-level > RISC-V Kconfig... > For the pair: > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Actually, I would like to take this back for patch 2. Per the discussion on the other thread about XIP [1], I don't think that KVM should be selecting alternatives like this. Would you mind if I picked up these patches & submitted them as a v2, alongside a patch trying to make sure that we do not clip the wings of of XIP kernels by selecting RISCV_ALTERNATIVE? Cheers, Conor. 1 - https://lore.kernel.org/all/20230322120907.2968494-1-Jason@zx2c4.com/ [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] RISC-V: KVM: Require alternatives 2023-03-23 17:57 ` Conor Dooley @ 2023-03-23 19:05 ` Andrew Jones 2023-03-24 11:32 ` Andrew Jones 1 sibling, 0 replies; 11+ messages in thread From: Andrew Jones @ 2023-03-23 19:05 UTC (permalink / raw) To: Conor Dooley Cc: linux-riscv, kvm-riscv, 'Palmer Dabbelt ', 'Anup Patel ', 'Paul Walmsley ', 'Atish Patra ', 'Albert Ou ' On Thu, Mar 23, 2023 at 05:57:14PM +0000, Conor Dooley wrote: > On Wed, Mar 22, 2023 at 07:40:14PM +0000, Conor Dooley wrote: > > On Wed, Mar 22, 2023 at 08:28:56PM +0100, Andrew Jones wrote: > > > KVM makes use of riscv_has_extension_unlikely() to check for the > > > svinval extension. riscv_has_extension_unlikely() is built on > > > alternatives, which means KVM should ensure alternatives support > > > is available. > > > > > > The first patch takes the opportunity to cleanup KVM's select > > > list. The second patch selects RISCV_ALTERNATIVE. > > > > Reminds me, I need to re-submit my patch doing that for the top-level > > RISC-V Kconfig... > > For the pair: > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Actually, I would like to take this back for patch 2. > Per the discussion on the other thread about XIP [1], I don't think > that KVM should be selecting alternatives like this. > Would you mind if I picked up these patches & submitted them as a v2, > alongside a patch trying to make sure that we do not clip the wings of > of XIP kernels by selecting RISCV_ALTERNATIVE? > Sounds good to me. Thanks, Conor. drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] RISC-V: KVM: Require alternatives 2023-03-23 17:57 ` Conor Dooley 2023-03-23 19:05 ` Andrew Jones @ 2023-03-24 11:32 ` Andrew Jones 2023-03-24 11:52 ` Conor Dooley 1 sibling, 1 reply; 11+ messages in thread From: Andrew Jones @ 2023-03-24 11:32 UTC (permalink / raw) To: Conor Dooley Cc: linux-riscv, kvm-riscv, 'Palmer Dabbelt ', 'Anup Patel ', 'Paul Walmsley ', 'Atish Patra ', 'Albert Ou ' On Thu, Mar 23, 2023 at 05:57:14PM +0000, Conor Dooley wrote: > On Wed, Mar 22, 2023 at 07:40:14PM +0000, Conor Dooley wrote: > > On Wed, Mar 22, 2023 at 08:28:56PM +0100, Andrew Jones wrote: > > > KVM makes use of riscv_has_extension_unlikely() to check for the > > > svinval extension. riscv_has_extension_unlikely() is built on > > > alternatives, which means KVM should ensure alternatives support > > > is available. > > > > > > The first patch takes the opportunity to cleanup KVM's select > > > list. The second patch selects RISCV_ALTERNATIVE. > > > > Reminds me, I need to re-submit my patch doing that for the top-level > > RISC-V Kconfig... > > For the pair: > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Actually, I would like to take this back for patch 2. > Per the discussion on the other thread about XIP [1], I don't think > that KVM should be selecting alternatives like this. > Would you mind if I picked up these patches & submitted them as a v2, > alongside a patch trying to make sure that we do not clip the wings of > of XIP kernels by selecting RISCV_ALTERNATIVE? Hi Conor, I take it that resubmitting these patches is no longer part of the plan. Should I rebase on "[PATCH v1 0/2] RISC-V: Fixes for riscv_has_extension[un]likely()'s alternative dependency" and change the select to a depends on? Thanks, drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] RISC-V: KVM: Require alternatives 2023-03-24 11:32 ` Andrew Jones @ 2023-03-24 11:52 ` Conor Dooley 2023-03-24 11:56 ` Andrew Jones 0 siblings, 1 reply; 11+ messages in thread From: Conor Dooley @ 2023-03-24 11:52 UTC (permalink / raw) To: Andrew Jones Cc: Conor Dooley, linux-riscv, kvm-riscv, 'Palmer Dabbelt ', 'Anup Patel ', 'Paul Walmsley ', 'Atish Patra ', 'Albert Ou ' [-- Attachment #1.1: Type: text/plain, Size: 2082 bytes --] On Fri, Mar 24, 2023 at 12:32:59PM +0100, Andrew Jones wrote: > On Thu, Mar 23, 2023 at 05:57:14PM +0000, Conor Dooley wrote: > > On Wed, Mar 22, 2023 at 07:40:14PM +0000, Conor Dooley wrote: > > > On Wed, Mar 22, 2023 at 08:28:56PM +0100, Andrew Jones wrote: > > > > KVM makes use of riscv_has_extension_unlikely() to check for the > > > > svinval extension. riscv_has_extension_unlikely() is built on > > > > alternatives, which means KVM should ensure alternatives support > > > > is available. > > > > > > > > The first patch takes the opportunity to cleanup KVM's select > > > > list. The second patch selects RISCV_ALTERNATIVE. > > > > > > Reminds me, I need to re-submit my patch doing that for the top-level > > > RISC-V Kconfig... > > > For the pair: > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > > Actually, I would like to take this back for patch 2. > > Per the discussion on the other thread about XIP [1], I don't think > > that KVM should be selecting alternatives like this. > > Would you mind if I picked up these patches & submitted them as a v2, > > alongside a patch trying to make sure that we do not clip the wings of > > of XIP kernels by selecting RISCV_ALTERNATIVE? > > Hi Conor, > > I take it that resubmitting these patches is no longer part of the plan. Ah crap, sorry. I meant to reply here after submitting and forgot. > Should I rebase on "[PATCH v1 0/2] RISC-V: Fixes for > riscv_has_extension[un]likely()'s alternative dependency" and change the > select to a depends on? I don't think you need to. Does KVM actually make use of alternatives, other than for riscv_has_extension_unlikely(), that are not gated by extension/erratum specific config options? With my patch 2/2, alternatives are always enabled for !XIP_KERNEL builds, and will fall back to the "slow" path in riscv_has_extension_unlikely() otherwise. If KVM doesn't need alternatives for another reason, I don't think you need to introduce a dependency on them and just inherit the decision made by CONFIG_RISCV. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] RISC-V: KVM: Require alternatives 2023-03-24 11:52 ` Conor Dooley @ 2023-03-24 11:56 ` Andrew Jones 2023-03-24 12:21 ` Anup Patel 0 siblings, 1 reply; 11+ messages in thread From: Andrew Jones @ 2023-03-24 11:56 UTC (permalink / raw) To: Conor Dooley Cc: Conor Dooley, linux-riscv, kvm-riscv, 'Palmer Dabbelt ', 'Anup Patel ', 'Paul Walmsley ', 'Atish Patra ', 'Albert Ou ' On Fri, Mar 24, 2023 at 11:52:13AM +0000, Conor Dooley wrote: > On Fri, Mar 24, 2023 at 12:32:59PM +0100, Andrew Jones wrote: > > On Thu, Mar 23, 2023 at 05:57:14PM +0000, Conor Dooley wrote: > > > On Wed, Mar 22, 2023 at 07:40:14PM +0000, Conor Dooley wrote: > > > > On Wed, Mar 22, 2023 at 08:28:56PM +0100, Andrew Jones wrote: > > > > > KVM makes use of riscv_has_extension_unlikely() to check for the > > > > > svinval extension. riscv_has_extension_unlikely() is built on > > > > > alternatives, which means KVM should ensure alternatives support > > > > > is available. > > > > > > > > > > The first patch takes the opportunity to cleanup KVM's select > > > > > list. The second patch selects RISCV_ALTERNATIVE. > > > > > > > > Reminds me, I need to re-submit my patch doing that for the top-level > > > > RISC-V Kconfig... > > > > For the pair: > > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > > > > Actually, I would like to take this back for patch 2. > > > Per the discussion on the other thread about XIP [1], I don't think > > > that KVM should be selecting alternatives like this. > > > Would you mind if I picked up these patches & submitted them as a v2, > > > alongside a patch trying to make sure that we do not clip the wings of > > > of XIP kernels by selecting RISCV_ALTERNATIVE? > > > > Hi Conor, > > > > I take it that resubmitting these patches is no longer part of the plan. > > Ah crap, sorry. I meant to reply here after submitting and forgot. > > > Should I rebase on "[PATCH v1 0/2] RISC-V: Fixes for > > riscv_has_extension[un]likely()'s alternative dependency" and change the > > select to a depends on? > > I don't think you need to. Does KVM actually make use of alternatives, > other than for riscv_has_extension_unlikely(), that are not gated by > extension/erratum specific config options? > > With my patch 2/2, alternatives are always enabled for !XIP_KERNEL > builds, and will fall back to the "slow" path in > riscv_has_extension_unlikely() otherwise. > If KVM doesn't need alternatives for another reason, I don't think you > need to introduce a dependency on them and just inherit the decision > made by CONFIG_RISCV. Ack, thanks, Conor. Anup, we can either drop patch 2/2 or the whole series, as you like. Thanks, drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] RISC-V: KVM: Require alternatives 2023-03-24 11:56 ` Andrew Jones @ 2023-03-24 12:21 ` Anup Patel 0 siblings, 0 replies; 11+ messages in thread From: Anup Patel @ 2023-03-24 12:21 UTC (permalink / raw) To: Andrew Jones Cc: Conor Dooley, Conor Dooley, linux-riscv, kvm-riscv, Palmer Dabbelt, Paul Walmsley, Atish Patra, Albert Ou On Fri, Mar 24, 2023 at 5:26 PM Andrew Jones <ajones@ventanamicro.com> wrote: > > On Fri, Mar 24, 2023 at 11:52:13AM +0000, Conor Dooley wrote: > > On Fri, Mar 24, 2023 at 12:32:59PM +0100, Andrew Jones wrote: > > > On Thu, Mar 23, 2023 at 05:57:14PM +0000, Conor Dooley wrote: > > > > On Wed, Mar 22, 2023 at 07:40:14PM +0000, Conor Dooley wrote: > > > > > On Wed, Mar 22, 2023 at 08:28:56PM +0100, Andrew Jones wrote: > > > > > > KVM makes use of riscv_has_extension_unlikely() to check for the > > > > > > svinval extension. riscv_has_extension_unlikely() is built on > > > > > > alternatives, which means KVM should ensure alternatives support > > > > > > is available. > > > > > > > > > > > > The first patch takes the opportunity to cleanup KVM's select > > > > > > list. The second patch selects RISCV_ALTERNATIVE. > > > > > > > > > > Reminds me, I need to re-submit my patch doing that for the top-level > > > > > RISC-V Kconfig... > > > > > For the pair: > > > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > > > > > > Actually, I would like to take this back for patch 2. > > > > Per the discussion on the other thread about XIP [1], I don't think > > > > that KVM should be selecting alternatives like this. > > > > Would you mind if I picked up these patches & submitted them as a v2, > > > > alongside a patch trying to make sure that we do not clip the wings of > > > > of XIP kernels by selecting RISCV_ALTERNATIVE? > > > > > > Hi Conor, > > > > > > I take it that resubmitting these patches is no longer part of the plan. > > > > Ah crap, sorry. I meant to reply here after submitting and forgot. > > > > > Should I rebase on "[PATCH v1 0/2] RISC-V: Fixes for > > > riscv_has_extension[un]likely()'s alternative dependency" and change the > > > select to a depends on? > > > > I don't think you need to. Does KVM actually make use of alternatives, > > other than for riscv_has_extension_unlikely(), that are not gated by > > extension/erratum specific config options? > > > > With my patch 2/2, alternatives are always enabled for !XIP_KERNEL > > builds, and will fall back to the "slow" path in > > riscv_has_extension_unlikely() otherwise. > > If KVM doesn't need alternatives for another reason, I don't think you > > need to introduce a dependency on them and just inherit the decision > > made by CONFIG_RISCV. > > Ack, thanks, Conor. > > Anup, we can either drop patch 2/2 or the whole series, as you like. If alternatives are going to be always enabled for !XIP_KERNEL then we can drop PATCH2. I am okay taking PATCH1. Regards, Anup _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-04-07 11:48 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-03-22 19:28 [PATCH 0/2] RISC-V: KVM: Require alternatives Andrew Jones 2023-03-22 19:28 ` [PATCH 1/2] RISC-V: KVM: Alphabetize selects Andrew Jones 2023-04-07 11:47 ` Anup Patel 2023-03-22 19:28 ` [PATCH 2/2] RISC-V: KVM: Require alternatives Andrew Jones 2023-03-22 19:40 ` [PATCH 0/2] " Conor Dooley 2023-03-23 17:57 ` Conor Dooley 2023-03-23 19:05 ` Andrew Jones 2023-03-24 11:32 ` Andrew Jones 2023-03-24 11:52 ` Conor Dooley 2023-03-24 11:56 ` Andrew Jones 2023-03-24 12:21 ` Anup Patel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox