From: Damien Le Moal <dlemoal@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org
Subject: Re: [PATCH 2/2] riscv: dts: canaan: Disable I/O devices unless used
Date: Thu, 9 May 2024 15:58:20 +0900 [thread overview]
Message-ID: <6d8ec78f-e138-4798-ba7d-4cf6ac08e8a7@kernel.org> (raw)
In-Reply-To: <f85d460efd7ad85ec59c9253c989b10a07f2ff24.1715163174.git.geert+renesas@glider.be>
On 5/8/24 7:20 PM, Geert Uytterhoeven wrote:
> It is considered good practice to disable on-SoC devices providing
> external I/O in the SoC-specific .dtsi, and enable them explicitly in
> the board-specific DTS files when actually wired-up and used.
>
> Hence:
> - Set the status of I/O devices in k210.dtsi to "disabled",
> - Override the status of used I/O devices in board-specific DTS files
> to "okay",
> - Drop unneeded status overrides in board DTS-specific files for the
> always-enabled pin controller.
>
> On e.g. MAiXBiT, this gets rid of an error message when probing the
> unused slave-only spi2 controller:
>
> dw_spi_mmio 50240000.spi: error -22: problem registering spi host
> dw_spi_mmio 50240000.spi: probe with driver dw_spi_mmio failed with error -22
>
> which is seen since commit 98d75b9ef282f6b9 ("spi: dw: Drop default
> number of CS setting").
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Looks good to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-05-09 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 10:20 [PATCH 0/2] riscv: dts: canaan: Unused devices cleanup Geert Uytterhoeven
2024-05-08 10:20 ` [PATCH 1/2] riscv: dts: canaan: Clean up serial aliases Geert Uytterhoeven
2024-05-09 6:56 ` Damien Le Moal
2024-05-08 10:20 ` [PATCH 2/2] riscv: dts: canaan: Disable I/O devices unless used Geert Uytterhoeven
2024-05-09 6:58 ` Damien Le Moal [this message]
2024-05-28 11:26 ` [PATCH 0/2] riscv: dts: canaan: Unused devices cleanup Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d8ec78f-e138-4798-ba7d-4cf6ac08e8a7@kernel.org \
--to=dlemoal@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox