Re: [PATCH 07/10] dt-bindings: reset: sophgo: Add CV18xx reset controller

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>, soc@lists.linux.dev
Cc: Chen Wang <unicorn_wang@outlook.com>,
	Inochi Amaoto <inochiama@outlook.com>,
	linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org,
	devicetree@vger.kernel.org, Haylen Chu <heylenay@outlook.com>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Reichel <sre@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH 07/10] dt-bindings: reset: sophgo: Add CV18xx reset controller
Date: Mon, 10 Feb 2025 09:49:58 +0100	[thread overview]
Message-ID: <703db762-93f4-45f6-a97b-5aea59620a03@kernel.org> (raw)
In-Reply-To: <20250209220646.1090868-8-alexander.sverdlin@gmail.com>

On 09/02/2025 23:06, Alexander Sverdlin wrote:
> Add DT bindings for CV18xx reset controller. The power/reboot driver is
> going to use only 4 bits from two different MMIO regions which can be
> potentially used by other subsystems/drivers, therefore the resources
> are not being claimed directly by the device/driver, but via syscons
> instead.
> 
> Link: https://github.com/sophgo/sophgo-doc/releases/download/sg2000-trm-v1.01/sg2000_trm_en.pdf
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
>  .../bindings/reset/sophgo,cv1800-reset.yaml   | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml
> 
> diff --git a/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml
> new file mode 100644
> index 000000000000..4f058f99df5f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/sophgo,cv1800-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cvitek CV18xx/Sophgo SG2000 Reset Controller
> +
> +maintainers:
> +  - Alexander Sverdlin <alexander.sverdlin@gmail.com>
> +
> +properties:
> +  compatible:
> +    const: sophgo,cv1800-reset
> +

Missing reset cells.

> +  sophgo,rtcsys-ctrl:
> +    description: phandle of the "RTCSYS_CTRL" syscon block
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +  sophgo,rtcsys-core:
> +    description: phandle of the "RTCSYS_CORE" syscon block
> +    $ref: /schemas/types.yaml#/definitions/phandle

This does not look right - entirely fake device. And your DTS next patch
proves it.

> +
> +required:
> +  - compatible
> +  - sophgo,rtcsys-ctrl
> +  - sophgo,rtcsys-core
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    soc-reset {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +        compatible = "sophgo,cv1800-reset";
> +        sophgo,rtcsys-ctrl = <&rtcsys_ctrl>;
> +        sophgo,rtcsys-core = <&rtcsys_core>;
> +    };
> +...

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv