RE: [PATCH v4 1/6] PCI: starfive: Use regulator APIs instead of GPIO APIs to enable the 3V3 power supply of PCIe slots

Hal Feng
2025-12-01T06:45:43Z

> On 25.11.25 15:56, Hal Feng wrote:
> The "enable-gpio" property is not documented in the dt-bindings and using
> GPIO APIs is not a standard method to enable or disable PCIe slot power, so
> use regulator APIs to replace them.
>
> Tested-by: Matthias Brugger <mbrugger@suse.com>
> Fixes: 39b91eb40c6a ("PCI: starfive: Add JH7110 PCIe controller")
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
> drivers/pci/controller/plda/pcie-starfive.c | 25 ++++++++++++---------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pci/controller/plda/pcie-starfive.c
> b/drivers/pci/controller/plda/pcie-starfive.c
> index 3caf53c6c082..298036c3e7f9 100644
> --- a/drivers/pci/controller/plda/pcie-starfive.c
> +++ b/drivers/pci/controller/plda/pcie-starfive.c
> @@ -55,7 +55,7 @@ struct starfive_jh7110_pcie {
> struct reset_control *resets;
> struct clk_bulk_data *clks;
> struct regmap *reg_syscon;
> - struct gpio_desc *power_gpio;
> + struct regulator *vpcie3v3;
> struct gpio_desc *reset_gpio;
> struct phy *phy;
>
> @@ -153,11 +153,13 @@ static int starfive_pcie_parse_dt(struct
> starfive_jh7110_pcie *pcie,
> return dev_err_probe(dev, PTR_ERR(pcie->reset_gpio),
> "failed to get perst-gpio\n");
>
> - pcie->power_gpio = devm_gpiod_get_optional(dev, "enable",
> - GPIOD_OUT_LOW);
> - if (IS_ERR(pcie->power_gpio))
> - return dev_err_probe(dev, PTR_ERR(pcie->power_gpio),
> - "failed to get power-gpio\n");
> + pcie->vpcie3v3 = devm_regulator_get_optional(dev, "vpcie3v3");
> + if (IS_ERR(pcie->vpcie3v3)) {
> + if (PTR_ERR(pcie->vpcie3v3) != -ENODEV)
> + return dev_err_probe(dev, PTR_ERR(pcie->vpcie3v3),
> + "failed to get vpcie3v3
> regulator\n");
> + pcie->vpcie3v3 = NULL;
> + }
>
> return 0;
> }
> @@ -270,8 +272,8 @@ static void starfive_pcie_host_deinit(struct
> plda_pcie_rp *plda)
> container_of(plda, struct starfive_jh7110_pcie, plda);
>
> starfive_pcie_clk_rst_deinit(pcie);
> - if (pcie->power_gpio)
> - gpiod_set_value_cansleep(pcie->power_gpio, 0);
> + if (pcie->vpcie3v3)
> + regulator_disable(pcie->vpcie3v3);
> starfive_pcie_disable_phy(pcie);
> }
>
> @@ -304,8 +306,11 @@ static int starfive_pcie_host_init(struct plda_pcie_rp
> *plda)
> if (ret)
> return ret;
>
> - if (pcie->power_gpio)
> - gpiod_set_value_cansleep(pcie->power_gpio, 1);
> + if (pcie->vpcie3v3) {
> + ret = regulator_enable(pcie->vpcie3v3);
> + if (ret)
> + dev_err_probe(dev, ret, "failed to enable vpcie3v3
> regulator\n");
> + }
>
> if (pcie->reset_gpio)
> gpiod_set_value_cansleep(pcie->reset_gpio, 1);

Hi, Manivannan and the other PCIe maintainers,

Could you please help review and merge this patch? Thanks.

Best regards,
Hal