From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2856C00140 for ; Wed, 24 Aug 2022 18:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IH/Ab/cBvuiMK36SRzgJenJfiy6YUiXO9THaYqQtF6Q=; b=1uK+8w8x40+bXS +BIcP0zZWhpV6lP3EeurCF63Sp8EHWe4L7AEQs5RnzMwpJsdWXY4Jba686MCByt4Rg159dtCe1L9A GciRzTayASW9yjWe3F9jbZQkcHZ6ZsOnKrn9XQlmk20ThNdtml/ZITXVdbVs8worLZppWVaP8UHqq x+zxQcBV6CIk17LwossbPvDWjegfGXJlrB9NHgqNkBem1JoFrLl8ptgszz9CgmdWD25iy2GAYfCG/ v+s1rek3nT1rr3Qu60ipnwnnk/lmsw3H1gvqmz+2kjEmGLbjNQmJN+8Uyqo3NNR6n6KVP+HY16jTc ia/7sw9g1k7uC3+DoQHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQugB-00F3VG-ET; Wed, 24 Aug 2022 18:00:39 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQug8-00F3SW-4J for linux-riscv@lists.infradead.org; Wed, 24 Aug 2022 18:00:37 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oQug4-0004qH-Mb; Wed, 24 Aug 2022 20:00:32 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: tglx@linutronix.de, maz@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, Conor.Dooley@microchip.com Cc: daniel.lezcano@linaro.org, anup@brainfault.org, Conor.Dooley@microchip.com, guoren@kernel.org, sagar.kadam@sifive.com, jrtc27@jrtc27.com, ajones@ventanamicro.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, qemu-riscv@nongnu.org, robh@kernel.org Subject: Re: [PATCH v4 2/4] dt-bindings: interrupt-controller: sifive,plic: add legacy riscv compatible Date: Wed, 24 Aug 2022 20:00:31 +0200 Message-ID: <7260367.4vTCxPXJkl@diego> In-Reply-To: <95fe8df7-581e-f7ec-be1f-1c6e06cb30a4@microchip.com> References: <20220823183319.3314940-1-mail@conchuod.ie> <3948407.AJdgDx1Vlc@diego> <95fe8df7-581e-f7ec-be1f-1c6e06cb30a4@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220824_110036_196765_1DBE45E2 X-CRM114-Status: GOOD ( 25.31 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Am Mittwoch, 24. August 2022, 19:55:17 CEST schrieb Conor.Dooley@microchip.= com: > On 24/08/2022 18:44, Heiko St=FCbner wrote: > > Am Dienstag, 23. August 2022, 20:33:18 CEST schrieb Conor Dooley: > >> From: Conor Dooley > >> > >> While "real" hardware might not use the compatible string "riscv,plic0" > >> it is present in the driver & QEMU uses it for automatically generated > >> virt machine dtbs. To avoid dt-validate problems with QEMU produced > >> dtbs, such as the following, add it to the binding. > >> > >> riscv-virt.dtb: plic@c000000: compatible: 'oneOf' conditional failed, = one must be fixed: > >> 'sifive,plic-1.0.0' is not one of ['sifive,fu540-c000-plic', '= starfive,jh7100-plic', 'canaan,k210-plic'] > >> 'sifive,plic-1.0.0' is not one of ['allwinner,sun20i-d1-plic'] > >> 'sifive,plic-1.0.0' was expected > >> 'thead,c900-plic' was expected > >> riscv-virt.dtb: plic@c000000: '#address-cells' is a required property > >> > >> Reported-by: Rob Herring > >> Link: https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-rob= h@kernel.org/ > >> Reviewed-by: Rob Herring > >> Signed-off-by: Conor Dooley > >> --- > >> .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/si= five,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controll= er/sifive,plic-1.0.0.yaml > >> index 92e0f8c3eff2..99e01f4d0a69 100644 > >> --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,pl= ic-1.0.0.yaml > >> +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,pl= ic-1.0.0.yaml > >> @@ -66,6 +66,11 @@ properties: > >> - enum: > >> - allwinner,sun20i-d1-plic > >> - const: thead,c900-plic > >> + - items: > >> + - const: sifive,plic-1.0.0 > >> + - const: riscv,plic0 > >> + deprecated: true > > = > > hmm, when setting this to deprecated, does this mean qemu was changed > > to not use that compatible anymore? > > = > > I.e. reading deprecated I'd assume that this is kept around for old qem= u builds? > = > I did not make that change to QEMU. From v1 [0]: > = > Rob: > > Conor: > >> In arm's virt.c they use the generic gic compatible & I don't see any > >> evidence of other archs using "qemu,foo" bindings. I suppose there's > >> always the option of just removing the "riscv,plic0" from the riscv's > >> virt.c > > > > I think we're pretty much stuck with what's in use already. > = > > I'm on the fence whether to mark it deprecated though if there is no = > > plan to 'fix' it. Doesn't really matter until the tools can selectively = > > remove deprecated properties from validation. > = > My interpretation was "do not use this compatible in any new devicetrees". > = > I don't really have any strong feelings here. Maybe the description is > sufficient? that makes sense then. Existing users can keep using it, but no-one should create new usages of it, so this looks good then Heiko _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv