From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ben Zong-You Xie <ben717@andestech.com>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: i2c: add support for AE350 I2C controller
Date: Thu, 22 Jan 2026 10:50:03 +0100 [thread overview]
Message-ID: <732a8967-4d87-4c5d-905f-cdc0629e9946@kernel.org> (raw)
In-Reply-To: <20260122-almond-pug-of-management-33d438@quoll>
On 22/01/2026 09:08, Krzysztof Kozlowski wrote:
>> +properties:
>> + compatible:
>> + oneOf:
>> + - items:
>> + - enum:
>> + - andestech,qilai-i2c
>> + - const: andestech,ae350-i2c
>> + - const: andestech,ae350-i2c
>
> Same question as before. Nothing in commit msg explains me above and you
> STILL DID NOT send your soc upstream which would help me to understand
To clarify: no top-level bindings for `git grep andestech,ae350`
> the relation between SoCs.
>
> Considering you did not even build check previous version, I do not give
> you any benefits of the doubt that this is correct code.
>
> Respond to previous review.
>
> That is a NAK and I am dropping it from the patchwork.
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-01-22 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 3:53 [PATCH v2 0/4] i2c: add support for Andes platform Ben Zong-You Xie via B4 Relay
2026-01-22 3:53 ` [PATCH v2 1/4] dt-bindings: i2c: add support for AE350 I2C controller Ben Zong-You Xie via B4 Relay
2026-01-22 8:08 ` Krzysztof Kozlowski
2026-01-22 9:50 ` Krzysztof Kozlowski [this message]
2026-01-22 3:53 ` [PATCH v2 2/4] i2c: add Andes I2C driver support Ben Zong-You Xie via B4 Relay
2026-01-22 3:53 ` [PATCH v2 3/4] MAINTAINERS: add an entry for Andes I2C driver Ben Zong-You Xie via B4 Relay
2026-01-22 3:53 ` [PATCH v2 4/4] riscv: dts: andes: qilai: add I2C controller Ben Zong-You Xie via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=732a8967-4d87-4c5d-905f-cdc0629e9946@kernel.org \
--to=krzk@kernel.org \
--cc=alex@ghiti.fr \
--cc=andi.shyti@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=ben717@andestech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox