Re: [PATCH v2 07/13] RISC-V: add auipc elements to parse_asm header

Heiko Stübner
2022-11-30T14:43:58Z

Am Mittwoch, 30. November 2022, 00:36:12 CET schrieb Conor Dooley:
> On Mon, Nov 28, 2022 at 11:26:26AM +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@vrull.eu>
> > RISC-V: add auipc elements to parse_asm header
>
> This header is no longer called parse_asm ;)

With this commit moving more in front, the naming fits again ;-)

> > +__RISCV_INSN_FUNCS(auipc, RVG_MASK_AUIPC, RVG_MATCH_AUIPC)
> > __RISCV_INSN_FUNCS(jalr, RVG_MASK_JALR, RVG_MATCH_JALR)
> > __RISCV_INSN_FUNCS(jal, RVG_MASK_JAL, RVG_MATCH_JAL)
> > __RISCV_INSN_FUNCS(c_jr, RVC_MASK_C_JR, RVC_MATCH_C_JR)
>
> This fixes the build error that's been lingering for a few patches, so
> please re-order things so as not to break bisection :)
>
> With the nits above fixed & assuming that this survives as its own
> commit:
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

I've moved it more in front now and reworded the commit message
a bit.