Re: [PATCH v2 08/13] RISC-V: add U-type imm parsing to parse_asm header

Heiko Stübner
2022-11-30T19:27:59Z

Am Mittwoch, 30. November 2022, 00:38:32 CET schrieb Conor Dooley:
> On Mon, Nov 28, 2022 at 11:26:27AM +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@vrull.eu>
> >
> > RISC-V: add U-type imm parsing to parse_asm header
>
> Ditto.
>
> > Similar to other existing types, allow extracting the immediate
> > for a U-type instruction.
> >
> > U-type immediates are special in that regard, that the value
> > in the instruction in bits [31:12] already represents the same
> > bits of the immediate, so no shifting is required.
> >
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu>
>
> How is this different to the patch I left an R-b for on v1?

Somehow with having changed so much for v2, it felt strange carrying
over many of the R-b-s. Though yeah, this one could've made it :-)

Heiko