Re: [PATCH v2 01/13] RISC-V: add prefix to all constants/macros in parse_asm.h

Heiko Stübner
2022-11-30T12:13:08Z

Am Dienstag, 29. November 2022, 23:19:57 CET schrieb Conor Dooley:
> On Mon, Nov 28, 2022 at 11:26:20AM +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@vrull.eu>
> >
> > Some of the constants and macros already have suitable
> > RV_, RVG_ or RVC_ prefixes.
> >
> > Extend this to the rest of the file as well, as we want
> > to use these things in a broader scope soon.
>
> What's up with the "weird" 57 character lines here?

that is my brain shouting "you need to wrap lines" too early.
I did make them longer now, but the line count won't change :-) .

> Either way, I hate these sort of diffs and my brain just switches off
> while trying to read them. Perhaps there's a way to make git spit these
> out that shows
> -
> +
> -
> +
> rather than
> -
> -
> +
> +

I know that feeling well :-)

> and I could be more confident, but it seems okay to me...
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

thanks

Heiko