From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: iommu@lists.linux.dev,
Marek Szyprowski <m.szyprowski@samsung.com>,
Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-m68k@lists.linux-m68k.org, netdev@vger.kernel.org,
Jim Quinlan <james.quinlan@broadcom.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
arm-soc <soc@kernel.org>
Subject: Re: [PATCH 1/6] dma-direct: add depdenencies to CONFIG_DMA_GLOBAL_POOL
Date: Mon, 9 Oct 2023 17:45:59 +0100 [thread overview]
Message-ID: <74e81490-1765-4f13-9fee-04b58696bbde@arm.com> (raw)
In-Reply-To: <20231009124805.GA7042@lst.de>
On 09/10/2023 1:48 pm, Christoph Hellwig wrote:
> On Mon, Oct 09, 2023 at 01:10:26PM +0200, Geert Uytterhoeven wrote:
>> RISCV_DMA_NONCOHERENT does not select DMA_GLOBAL_POOL,
>> ARCH_R9A07G043 selects DMA_GLOBAL_POOL.
>> RISCV_DMA_NONCOHERENT does select DMA_DIRECT_REMAP if MMU.
Bleh, guess I should have known better than to trust my Monday morning
memory without double-checking the code :)
> Yeah, and we'll basically need to split RISCV_DMA_NONCOHERENT into
> an option for each type of non-coherent support. This is why we
> should never have added support for any of the non-standard versions,
> as it's turning into a giant mess.
Indeed the main point I was trying to get at is for ARCH_R9A07G043 (or
rather possibly ERRATA_ANDES_CMO) to not select RISCV_DMA_NONCOHERENT in
its current form, since that ending up selecting DMA_DIRECT_REMAP on a
platform which can't support it is the thing that's most obviously wrong.
Thanks,
Robin.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2023-10-09 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231009074121.219686-1-hch@lst.de>
[not found] ` <20231009074121.219686-2-hch@lst.de>
2023-10-09 8:43 ` [PATCH 1/6] dma-direct: add depdenencies to CONFIG_DMA_GLOBAL_POOL Geert Uytterhoeven
2023-10-09 9:16 ` Christoph Hellwig
2023-10-09 9:34 ` Geert Uytterhoeven
2023-10-09 9:43 ` Christoph Hellwig
2023-10-09 9:51 ` Geert Uytterhoeven
2023-10-09 10:04 ` Robin Murphy
2023-10-09 11:10 ` Geert Uytterhoeven
2023-10-09 12:48 ` Christoph Hellwig
2023-10-09 16:45 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74e81490-1765-4f13-9fee-04b58696bbde@arm.com \
--to=robin.murphy@arm.com \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=james.quinlan@broadcom.com \
--cc=linux-imx@nxp.com \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=shenwei.wang@nxp.com \
--cc=soc@kernel.org \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox