From: Li Huafei <lihuafei1@huawei.com>
To: Palmer Dabbelt <palmer@rivosinc.com>, <aou@eecs.berkeley.edu>,
<liaochang1@huawei.com>, <rdunlap@infradead.org>,
<u.kleine-koenig@pengutronix.de>,
Paul Walmsley <paul.walmsley@sifive.com>, <lizhengyu3@huawei.com>,
Palmer Dabbelt <palmer@dabbelt.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<kexec@lists.infradead.org>
Subject: Re: [PATCH 1/2] RISC-V: kexec: Fix memory leak of fdt buffer
Date: Wed, 7 Dec 2022 09:25:26 +0800 [thread overview]
Message-ID: <75925d58-ee92-e0f0-d1df-d8bd1d3fcfe3@huawei.com> (raw)
In-Reply-To: <167027930833.25586.2671834159281320615.b4-ty@rivosinc.com>
On 2022/12/6 6:28, Palmer Dabbelt wrote:
> On Fri, 4 Nov 2022 17:56:57 +0800, Li Huafei wrote:
>> This is reported by kmemleak detector:
>>
>> unreferenced object 0xff60000082864000 (size 9588):
>> comm "kexec", pid 146, jiffies 4294900634 (age 64.788s)
>> hex dump (first 32 bytes):
>> d0 0d fe ed 00 00 12 ed 00 00 00 48 00 00 11 40 ...........H...@
>> 00 00 00 28 00 00 00 11 00 00 00 02 00 00 00 00 ...(............
>> backtrace:
>> [<00000000f95b17c4>] kmemleak_alloc+0x34/0x3e
>> [<00000000b9ec8e3e>] kmalloc_order+0x9c/0xc4
>> [<00000000a95cf02e>] kmalloc_order_trace+0x34/0xb6
>> [<00000000f01e68b4>] __kmalloc+0x5c2/0x62a
>> [<000000002bd497b2>] kvmalloc_node+0x66/0xd6
>> [<00000000906542fa>] of_kexec_alloc_and_setup_fdt+0xa6/0x6ea
>> [<00000000e1166bde>] elf_kexec_load+0x206/0x4ec
>> [<0000000036548e09>] kexec_image_load_default+0x40/0x4c
>> [<0000000079fbe1b4>] sys_kexec_file_load+0x1c4/0x322
>> [<0000000040c62c03>] ret_from_syscall+0x0/0x2
>>
>> [...]
>
> Applied, thanks!
>
> [1/2] RISC-V: kexec: Fix memory leak of fdt buffer
> https://git.kernel.org/palmer/c/96df59b1ae23
> [2/2] RISC-V: kexec: Fix memory leak of elf header buffer
> https://git.kernel.org/palmer/c/cbc32023ddbd
>
> These are on for-next. They'd probably be fine fixes candidates had I gotten
> to them in time, but it's pretty late and a leak during kexec doesn't seem like
> a show-stopper. They'll get backported anyway, but this way they get an extra
> week in linux-next just to see.
>
I have no problem with it being merged into the -next branch. Thanks Palmer!
> Best regards,
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-07 1:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 9:56 [PATCH 1/2] RISC-V: kexec: Fix memory leak of fdt buffer Li Huafei
2022-11-04 9:56 ` [PATCH 2/2] RISC-V: kexec: Fix memory leak of elf header buffer Li Huafei
2022-11-04 12:51 ` Conor Dooley
2022-11-04 12:50 ` [PATCH 1/2] RISC-V: kexec: Fix memory leak of fdt buffer Conor Dooley
2022-11-07 1:30 ` liaochang (A)
2022-12-05 22:28 ` Palmer Dabbelt
2022-12-07 1:24 ` Li Huafei
2022-12-07 1:25 ` Li Huafei [this message]
2022-12-05 22:40 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75925d58-ee92-e0f0-d1df-d8bd1d3fcfe3@huawei.com \
--to=lihuafei1@huawei.com \
--cc=aou@eecs.berkeley.edu \
--cc=kexec@lists.infradead.org \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lizhengyu3@huawei.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=rdunlap@infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox