Re: [PATCH -fixes] riscv: cpufeature: Do not drop Linux-internal extensions

From: Samuel Holland <samuel.holland@sifive.com>
To: Palmer Dabbelt <palmer@dabbelt.com>, linux-riscv@lists.infradead.org
Cc: "Albert Ou" <aou@eecs.berkeley.edu>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	"Andy Chiu" <andy.chiu@sifive.com>,
	"Charlie Jenkins" <charlie@rivosinc.com>,
	"Clément Léger" <cleger@rivosinc.com>,
	"Conor Dooley" <conor@kernel.org>,
	"Evan Green" <evan@rivosinc.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -fixes] riscv: cpufeature: Do not drop Linux-internal extensions
Date: Thu, 18 Jul 2024 16:34:39 -0500	[thread overview]
Message-ID: <75ba30e5-3371-4ca9-9dbd-af7f78907c30@sifive.com> (raw)
In-Reply-To: <20240718213011.2600150-1-samuel.holland@sifive.com>

On 2024-07-18 4:29 PM, Samuel Holland wrote:
> The Linux-internal Xlinuxenvcfg ISA extension is omitted from the
> riscv_isa_ext array because it has no DT binding and should not appear
> in /proc/cpuinfo. The logic added in commit 625034abd52a ("riscv: add
> ISA extensions validation callback") assumes all extensions are included
> in riscv_isa_ext, and so riscv_resolve_isa() wrongly drops Xlinuxenvcfg
> from the final ISA string. Instead, accept such Linux-internal ISA
> extensions as if they have no validation callback.
> 
> Fixes: 625034abd52a ("riscv: add ISA extensions validation callback")

Apologies for the incorrect subject line. This fixes a commit in for-next, so
this patch is targeting for-next.

> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
> ---
> 
>  arch/riscv/kernel/cpufeature.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv