From: Marc Zyngier <maz@kernel.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: prabhakar.mahadev-lad.rj@bp.renesas.com, tglx@linutronix.de,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org, geert+renesas@glider.be,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
prabhakar.csengg@gmail.com, biju.das.jz@bp.renesas.com
Subject: Re: [PATCH] irqchip/sifive-plic: Make struct irq_chip const
Date: Thu, 11 Aug 2022 18:19:38 +0100 [thread overview]
Message-ID: <771e663cebf23735782a7ce41e51d33e@kernel.org> (raw)
In-Reply-To: <mhng-16e473fc-4513-4998-b732-9059d2c0b870@palmer-mbp2014>
On 2022-08-11 17:53, Palmer Dabbelt wrote:
> On Fri, 24 Jun 2022 10:56:39 PDT (-0700),
> prabhakar.mahadev-lad.rj@bp.renesas.com wrote:
>> These should be const, so make it so.
>>
>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>> ---
>> drivers/irqchip/irq-sifive-plic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-sifive-plic.c
>> b/drivers/irqchip/irq-sifive-plic.c
>> index bb87e4c3b88e..173446cc9204 100644
>> --- a/drivers/irqchip/irq-sifive-plic.c
>> +++ b/drivers/irqchip/irq-sifive-plic.c
>> @@ -176,7 +176,7 @@ static void plic_irq_eoi(struct irq_data *d)
>> }
>> }
>>
>> -static struct irq_chip plic_chip = {
>> +static const struct irq_chip plic_chip = {
>> .name = "SiFive PLIC",
>> .irq_mask = plic_irq_mask,
>> .irq_unmask = plic_irq_unmask,
>
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> Not sure if this got picked up somewhere, but it looks fine to me.
It probably needs respinning (the PLIC code has evolved a bit since).
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2022-08-11 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 17:56 [PATCH] irqchip/sifive-plic: Make struct irq_chip const Lad Prabhakar
2022-08-11 16:53 ` Palmer Dabbelt
2022-08-11 17:19 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771e663cebf23735782a7ce41e51d33e@kernel.org \
--to=maz@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox