From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95894C10F14 for ; Thu, 18 Apr 2019 17:45:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 602012186A for ; Thu, 18 Apr 2019 17:45:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P3nXnjA8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="hSKwbyj0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 602012186A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:From:Date: MIME-Version:Subject:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jCnQnQ/OhCoUTFgX/tUvEs//zHcN+7osR8XIUikEaGI=; b=P3nXnjA8pkBtie/iX77M7xb0c Hk0YizR84bgvrDOTpg68d1Rej/vsEGMWvzs2Od+IAjXj0NopdIlWuJJXwtZodsW9UTKUIFNLpWsYB rVZZmbq1i83eJQAv/l7yZagnkXfARGaluyeZsBe5nWinZOUzv00CAbpNZ1ceaCr1KToW+CH3/Aue8 5tEAZCrf0JItMLd1osfjHj/Wc/F1vLv+aW/b83MxLHtsRPNOrjkzDwTnqaRK0TAYPd48QKUON8aCD W83dHPWVGb3gzVNd4Tba9AkjU9equNSLlHD/zQxZDFfet/wh2wrybMxJP8uerv0uDVaxmaRAgyfZ8 k2Qf350MQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHB5t-00066R-KW; Thu, 18 Apr 2019 17:45:05 +0000 Received: from node.akkea.ca ([192.155.83.177]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHB5h-0005p2-DB; Thu, 18 Apr 2019 17:44:54 +0000 Received: by node.akkea.ca (Postfix, from userid 33) id 4926C4E204B; Thu, 18 Apr 2019 17:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1555609490; bh=lhBxiRLUZJ5Ub6CaqN1pNkADQcPLYCoqT1MnSfYZbZs=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=hSKwbyj0Xms6ltQRU9iZCuKdFSSHREVmKr88vw8ckauAhVn47pE80hhlsMlgK5yt3 piP/28r+NZrtpYcf7Kd5T5o0SkiwwNTHLGpYFt18Pw0KSli4lp6WbCBcxnV8a5qhr0 w+eZLUa3uspaFQkSrNQxsOZ7EA3MC6ejxkQB+lv4= To: Rob Herring Subject: Re: [PATCH v5 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Date: Thu, 18 Apr 2019 10:44:50 -0700 From: Angus Ainslie In-Reply-To: <20190418151350.GC32345@bogus> References: <20190417165514.18689-1-angus@akkea.ca> <20190417165514.18689-2-angus@akkea.ca> <20190418151350.GC32345@bogus> Message-ID: <79d43377285d6897847ac1452afbb18a@www.akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_104453_491600_2933296C X-CRM114-Status: GOOD ( 17.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jacky Bai , Palmer Dabbelt , Bruno Thomsen , m.felsch@pengutronix.de, Guo Ren , Manivannan Sadhasivam , linux-riscv@lists.infradead.org, Fabio Estevam , Andrey Smirnov , Kevin Hilman , NXP Linux Team , Thierry Reding , devicetree@vger.kernel.org, Albert Ou , Sascha Hauer , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , linux-mediatek@lists.infradead.org, Paul Walmsley , Jonathan Cameron , Matthias Brugger , linux-arm-kernel@lists.infradead.org, Aisheng Dong , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , angus.ainslie@puri.sm, Shawn Guo Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Hi Rob, On 2019-04-18 08:13, Rob Herring wrote: > On Wed, Apr 17, 2019 at 09:55:12AM -0700, Angus Ainslie (Purism) wrote: >> This is the development kit board for the Librem 5. The current level >> of >> support yields a working console and is able to boot userspace from >> the >> Network or eMMC. >> >> Additional subsystems that are active : >> >> - Both USB ports >> - SD card socket >> - WiFi usdhc >> - WWAN modem >> - GNSS >> - GPIO keys >> - LEDs >> - gyro >> - magnetometer >> - touchscreen >> - pwm >> - backlight >> - haptic motor >> >> Signed-off-by: Angus Ainslie (Purism) >> --- >> arch/arm64/boot/dts/freescale/Makefile | 1 + >> .../dts/freescale/imx8mq-librem5-devkit.dts | 833 >> ++++++++++++++++++ >> 2 files changed, 834 insertions(+) >> create mode 100644 >> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> >> diff --git a/arch/arm64/boot/dts/freescale/Makefile >> b/arch/arm64/boot/dts/freescale/Makefile >> index 0bd122f60549..c043aca66572 100644 >> --- a/arch/arm64/boot/dts/freescale/Makefile >> +++ b/arch/arm64/boot/dts/freescale/Makefile >> @@ -22,6 +22,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb >> >> dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8mq-evk.dtb >> +dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-rmb3.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-zest.dtb >> dtb-$(CONFIG_ARCH_MXC) += imx8qxp-mek.dtb >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> new file mode 100644 >> index 000000000000..846a72dc7640 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > >> +&usb3_phy0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + port@0 { >> + reg = <0>; >> + >> + typec_hs: endpoint { >> + remote-endpoint = <&usb_con_hs>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + typec_ss: endpoint { >> + remote-endpoint = <&usb_con_ss>; >> + }; >> + }; > > This is wrong. The graph should be between the USB controller and the > connector. The phy is not involved. > >> +}; >> + >> +&usb3_phy1 { >> + status = "okay"; >> +}; >> + >> +&usb_dwc3_0 { >> + extcon = <&typec_ptn5100>; > > extcon is deprecated and you should only have the usb-connector > binding. > From the controller, you can walk the graph to the connector. > I not sure that I'm clear on what you mean. Here's what I think you want it changed to. diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts index 846a72dc7640..7b8770fdc5fb 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts @@ -755,51 +755,50 @@ }; &uart4 { /* BT */ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart4>, <&pinctrl_bt>; uart-has-rtscts; status = "okay"; }; &usb3_phy0 { + status = "okay"; +}; + +&usb3_phy1 { + status = "okay"; +}; + +&usb_dwc3_0 { #address-cells = <1>; #size-cells = <0>; + dr_mode = "otg"; status = "okay"; port@0 { reg = <0>; typec_hs: endpoint { remote-endpoint = <&usb_con_hs>; }; }; port@1 { reg = <1>; typec_ss: endpoint { remote-endpoint = <&usb_con_ss>; }; }; }; -&usb3_phy1 { - status = "okay"; -}; - -&usb_dwc3_0 { - extcon = <&typec_ptn5100>; - dr_mode = "otg"; - status = "okay"; -}; - &usb_dwc3_1 { dr_mode = "host"; status = "okay"; }; Thanks Angus >> + dr_mode = "otg"; >> + status = "okay"; >> +}; _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv