From: Randy Dunlap <rdunlap@infradead.org>
To: Charlie Jenkins <charlie@rivosinc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Ron Economos <re@w6rz.net>
Cc: Palmer Dabbelt <palmer@rivosinc.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Support rv32 ULEB128 test
Date: Wed, 6 Dec 2023 09:00:38 -0800 [thread overview]
Message-ID: <7b27e5db-16b8-400e-a94b-a36f65205654@infradead.org> (raw)
In-Reply-To: <20231122-module_fixup-v2-1-dfb9565e9ea5@rivosinc.com>
Hi,
On 11/22/23 15:35, Charlie Jenkins wrote:
> Use opcodes available to both rv32 and rv64 in uleb128 module linking
> test.
>
> Fixes: af71bc194916 ("riscv: Add tests for riscv module loading")
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/lkml/1d7c71ee-5742-4df4-b8ef-a2aea0a624eb@infradead.org/
> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> Support module linking tests on rv32 toolchains with uleb128 support.
I'm still seeing build errors on this test module.
Can someone get this patch merged, please?
Thanks.
> ---
> Changes in v2:
> - Drop patch covered in different series
> - Link to v1: https://lore.kernel.org/r/20231117-module_fixup-v1-0-62bb777f6825@rivosinc.com
> ---
> arch/riscv/kernel/tests/module_test/test_uleb128.S | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/riscv/kernel/tests/module_test/test_uleb128.S b/arch/riscv/kernel/tests/module_test/test_uleb128.S
> index 90f22049d553..8515ed7cd8c1 100644
> --- a/arch/riscv/kernel/tests/module_test/test_uleb128.S
> +++ b/arch/riscv/kernel/tests/module_test/test_uleb128.S
> @@ -6,13 +6,13 @@
> .text
> .global test_uleb_basic
> test_uleb_basic:
> - ld a0, second
> + lw a0, second
> addi a0, a0, -127
> ret
>
> .global test_uleb_large
> test_uleb_large:
> - ld a0, fourth
> + lw a0, fourth
> addi a0, a0, -0x07e8
> ret
>
> @@ -22,10 +22,10 @@ first:
> second:
> .reloc second, R_RISCV_SET_ULEB128, second
> .reloc second, R_RISCV_SUB_ULEB128, first
> - .dword 0
> + .word 0
> third:
> .space 1000
> fourth:
> .reloc fourth, R_RISCV_SET_ULEB128, fourth
> .reloc fourth, R_RISCV_SUB_ULEB128, third
> - .dword 0
> + .word 0
>
> ---
> base-commit: 9bacdd8996c77c42ca004440be610692275ff9d0
> change-id: 20231117-module_fixup-699787d9c567
--
~Randy
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-12-06 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 23:35 [PATCH v2] Support rv32 ULEB128 test Charlie Jenkins
2023-12-06 17:00 ` Randy Dunlap [this message]
2023-12-07 15:20 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b27e5db-16b8-400e-a94b-a36f65205654@infradead.org \
--to=rdunlap@infradead.org \
--cc=aou@eecs.berkeley.edu \
--cc=charlie@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=re@w6rz.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).