Re: [PATCH v5 00/21] Enable drm/imagination BXM-4-64 Support for LicheePi 4A

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, drew@pdp7.com,
	guoren@kernel.org, wefu@redhat.com, jassisinghbrar@gmail.com,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, frank.binns@imgtec.com,
	matt.coster@imgtec.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	simona@ffwll.ch, ulf.hansson@linaro.org, jszhang@kernel.org,
	p.zabel@pengutronix.de, m.szyprowski@samsung.com,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 00/21] Enable drm/imagination BXM-4-64 Support for LicheePi 4A
Date: Mon, 3 Mar 2025 18:43:56 +0100	[thread overview]
Message-ID: <7ba53937-7922-41da-a7ed-909ce620db1f@kernel.org> (raw)
In-Reply-To: <90d0d409-f374-4e06-bc69-b9bf0622959d@samsung.com>

On 03/03/2025 09:38, Michal Wilczynski wrote:
> 
> 
> On 2/21/25 10:12, Krzysztof Kozlowski wrote:
>> On Wed, Feb 19, 2025 at 03:02:18PM +0100, Michal Wilczynski wrote:
>>> The LicheePi 4A board, featuring the T-HEAD TH1520 SoC, includes an Imagination
>>> Technologies BXM-4-64 GPU. Initial support for this GPU was provided through a
>>> downstream driver [1]. Recently, efforts have been made to upstream support for
>>> the Rogue family GPUs, which the BXM-4-64 is part of [2].
>>>
>>> While the initial upstream driver focused on the AXE-1-16 GPU, newer patches
>>> have introduced support for the BXS-4-64 GPU [3]. The modern upstream
>>> drm/imagination driver is expected to support the BXM-4-64 as well [4][5]. As
>>> this support is being developed, it's crucial to upstream the necessary glue
>>> code including clock and power-domain drivers so they're ready for integration
>>> with the drm/imagination driver.
>>>
>>
>> This is v5 of big patchset which became huge. I understand you did like
>> that for v1 which was RFC. But it stopped being RFC.
>>
>> Split your patchset, keeping versioning and changelog, per subsystem.
> 
> Sorry for the late reply—I didn't have access to email. I agree with
> your suggestion and will send the clock changes, firmware/power domain,
> reset, and drm/imagination updates as separate patchsets for merging.

How did you implement above comment? You did the split, right? Where is
versioning and where are changelogs?

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv