From: Dmitry Safonov <dima@arista.com>
To: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
Cc: Juri Lelli <juri.lelli@redhat.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
James Hogan <jhogan@kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Ben Segall <bsegall@google.com>,
linux-riscv@lists.infradead.org,
Vincent Chen <deanbo422@gmail.com>, Will Deacon <will@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Paul Burton <paulburton@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
Jiri Slaby <jslaby@suse.com>, Petr Mladek <pmladek@suse.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Steven Rostedt <rostedt@goodmis.org>,
Greentime Hu <green.hu@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Michal Simek <monstr@monstr.eu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mips@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCHv2 01/50] kallsyms/printk: Add loglvl to print_ip_sym()
Date: Fri, 17 Apr 2020 23:59:00 +0100 [thread overview]
Message-ID: <7d17eaf8-a3a8-eaba-ff80-e857135571e1@arista.com> (raw)
In-Reply-To: <97ea305c0d336f3c36a804b37e6bbb4b1bbf24fd.camel@perches.com>
Hi Joe,
On 3/16/20 3:29 PM, Joe Perches wrote:
> On Mon, 2020-03-16 at 14:38 +0000, Dmitry Safonov wrote:
>> print_ip_sym() needs to have a log level parameter to comply with other
>> parts being printed. Otherwise, half of the expected backtrace would be
>> printed and other may be missing with some logging level.
>
> There are 15 instances of print_ip_sym.
>
> Perhaps it'd be better to get rid of print_ip_sym
> altogether by expanding it in-place instead.
I tried this and format-string + two casts to (void *) take some space
and the resulting printk() doesn't fit 80 cols.
I guess, it's minor and it can be done on the top of v3..
>
>> arch/microblaze/kernel/unwind.c | 2 +-
>> arch/mips/kernel/traps.c | 4 ++--
>> arch/nds32/kernel/traps.c | 4 ++--
>> arch/riscv/kernel/stacktrace.c | 2 +-
>> include/linux/kallsyms.h | 4 ++--
>> kernel/locking/lockdep.c | 4 ++--
>> kernel/sched/core.c | 6 ++----
>> kernel/trace/ftrace.c | 8 ++++----
>> tools/include/linux/kallsyms.h | 2 +-
>
>
Thanks,
Dmitry
next prev parent reply other threads:[~2020-04-17 22:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 14:38 [PATCHv2 00/50] Add log level to show_stack() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 01/50] kallsyms/printk: Add loglvl to print_ip_sym() Dmitry Safonov
2020-03-16 15:29 ` Joe Perches
2020-04-17 22:59 ` Dmitry Safonov [this message]
2020-03-16 14:38 ` [PATCHv2 27/50] riscv: Add show_stack_loglvl() Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d17eaf8-a3a8-eaba-ff80-e857135571e1@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=bsegall@google.com \
--cc=deanbo422@gmail.com \
--cc=dietmar.eggemann@arm.com \
--cc=green.hu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhogan@kernel.org \
--cc=joe@perches.com \
--cc=jslaby@suse.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulburton@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox